NV items naming error.

[hacker-cb]

Currently we are working for backup migration 2538 <-> 2652 and seems that we found some naming error.

zigbee-herdsman/src/adapter/z-stack/constants/common.ts

Line 143 in 7e4b3f0

LEGACY_TCLK_TABLE_START = 257, // Valid for <= Z-Stack 3.0.x

257 = 0x101

ZComDef.h from the TI Z-Stack 1.2

// NV Items Reserved for Trust Center Link Key Table entries
// 0x0101 - 0x01FF
#define ZCD_NV_TCLK_TABLE_START           0x0101
#define ZCD_NV_TCLK_TABLE_END             0x01FF

TI Z-Stack 3.0:

// NV Items Reserved for Trust Center Link Key Table entries
// 0x0101 - 0x01FF
#define ZCD_NV_TCLK_SEED                  0x0101  //Seed
#define ZCD_NV_TCLK_JOIN_DEV              0x0102  //Nv Id where Joining device store their APS key. Key is in plain text.
#define ZCD_NV_TCLK_DEFAULT               0x0103  //Not accually a Nv Item but Id used by SecMgr

#define ZCD_NV_TCLK_IC_TABLE_START        0x0104  //IC keys, refered with shift byte
#define ZCD_NV_TCLK_IC_TABLE_END          0x0110

#define ZCD_NV_TCLK_TABLE_START           0x0111  //Entries to store users of the keys
#define ZCD_NV_TCLK_TABLE_END             0x01FF

I Z-Stack 3.x

// NV Items Reserved for Trust Center Link Key Table entries
// 0x0101 - 0x01FF
#define ZCD_NV_TCLK_SEED                  0x0101  //Seed
#define ZCD_NV_TCLK_JOIN_DEV              0x0102  //Nv Id where Joining device store their APS key. Key is in plain text.
#define ZCD_NV_TCLK_DEFAULT               0x0103  //Not accually a Nv Item but Id used by SecMgr

#define ZCD_NV_LEGACY_TCLK_IC_TABLE_START 0x0104  // Deprecated. Refer to ZCD_NV_EX_TCLK_IC_TABLE
#define ZCD_NV_LEGACY_TCLK_IC_TABLE_END   0x0110  // IC keys, refered with shift byte

#define ZCD_NV_LEGACY_TCLK_TABLE_START    0x0111  // Deprecated. Refer to ZCD_NV_EX_TCLK_TABLE
#define ZCD_NV_LEGACY_TCLK_TABLE_END      0x01FF

Also currently for 3.0 you backup table 0x0101 with length 16 bytes instead of backup table 0x0111 with length 19 bytes.
@Koenkk which table we need to really backup in your opinion? 0x0101 or 0x0111?

We will prepare fix with names.

[hacker-cb]

Fixed in #234