Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid ID for LEGACY_TCLK_TABLE_START #234

Merged
merged 9 commits into from
Oct 9, 2020
Merged

Fix invalid ID for LEGACY_TCLK_TABLE_START #234

merged 9 commits into from
Oct 9, 2020

Conversation

hacker-cb
Copy link
Contributor

Fix for #233

@hacker-cb
Copy link
Contributor Author

Currently backup fails with

Error: SREQ '--> SYS - osalNvRead - {"id":511,"product":2,"offset":0,"osal":true}' failed with status '(0x02: INVALID_PARAM)' (expected '(0x00: SUCCESS)')

So, I continue to work

@hacker-cb
Copy link
Contributor Author

hacker-cb commented Oct 8, 2020

Now all done.
Was tested on 2538 and 2652.
@Koenkk You can merge this.

P.S. Bi-directional backup migration beween 2538 and 2562 can work with this PR. I will make another PR for such migration tomorrow.

@hacker-cb
Copy link
Contributor Author

hacker-cb commented Oct 8, 2020

Please keep in mind, that it is breaking changes in coordinator_backup.json:

ZCD_NV_TCLK_SEED was added with ID 257
LEGACY_TCLK_TABLE_START now has id 273 and another length. (before it had ID 257 which is wrong)

@hacker-cb hacker-cb mentioned this pull request Oct 8, 2020
@hacker-cb
Copy link
Contributor Author

Please wait before merge. I will submit one small patch to tests

@hacker-cb hacker-cb closed this Oct 8, 2020
@hacker-cb hacker-cb reopened this Oct 8, 2020
@hacker-cb
Copy link
Contributor Author

Now it's ok :)

@Koenkk
Copy link
Owner

Koenkk commented Oct 8, 2020

This will break https://github.com/Koenkk/zigbee-herdsman/blob/master/src/adapter/z-stack/adapter/startZnp.ts#L191 (zstack 1.2), it will write to 273 instead of 257 after this. We should add:

    LEGACY_TCLK_TABLE_START_12 = 257, // Valid for <= Z-Stack 1.2
    LEGACY_TCLK_TABLE_START_30 = 273, // Valid for <= Z-Stack 3.0.x

@hacker-cb
Copy link
Contributor Author

hacker-cb commented Oct 8, 2020

I added LEGACY_TCLK_TABLE_START_12 but instead of using LEGACY_TCLK_TABLE_START_30 I suggest to keep LEGACY_TCLK_TABLE_START

@hacker-cb
Copy link
Contributor Author

@Koenkk what about to merge this?

@Koenkk
Copy link
Owner

Koenkk commented Oct 9, 2020

@hacker-cb yes, thanks!

@Koenkk Koenkk merged commit 13a4455 into Koenkk:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants