Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zStack 3.x.0 <-> zStack 3.0.x bidirectional migration #235

Merged
merged 12 commits into from
Oct 12, 2020
Merged

zStack 3.x.0 <-> zStack 3.0.x bidirectional migration #235

merged 12 commits into from
Oct 12, 2020

Conversation

hacker-cb
Copy link
Contributor

Was tested with 2538 and 2652 adapters on Zigbee network with 45 devices.
Should be meged after #234

@hacker-cb
Copy link
Contributor Author

I don't know why tests was failed on ci. My local tests are fine.

@hacker-cb
Copy link
Contributor Author

In any case we need to rebase it after merging #234

@hacker-cb
Copy link
Contributor Author

hacker-cb commented Oct 9, 2020 •
edited
Loading

@Koenkk I rebased this PR to master, but tests failed again, but there is no problem when I run npm run test in my PC.
Could you point me, which is wrong?

@Koenkk
Copy link
Owner

Koenkk commented Oct 9, 2020 •
edited
Loading

It fails because tests are missing for the new functionality. You can reproduce the result by running npm run test-with-coverage and view the coverage report in the created coverage directory (search for index.html), everything should be 100%.

EDIT: sorry, I see you wrote tests, but not everything is covered

@hacker-cb
Copy link
Contributor Author

@Koenkk now all tests are ok

@Koenkk
Copy link
Owner

Koenkk commented Oct 12, 2020

Thanks!

@Koenkk Koenkk merged commit 370dc74 into Koenkk:master Oct 12, 2020
Koenkk added a commit that referenced this pull request Oct 12, 2020
@Koenkk
Use debug with namespace. #235
69bf482
Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Oct 12, 2020
@Koenkk
Update Requires repairing docs. Koenkk/zigbee-herdsman#235
0191abe
@hacker-cb hacker-cb deleted the zstack_3_migrate_backup branch October 12, 2020 16:45
Koenkk added a commit to Koenkk/zigbee2mqtt.io that referenced this pull request Nov 1, 2020
@Koenkk
Update Requires repairing docs. Koenkk/zigbee-herdsman#235
2a743f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacker-cb @Koenkk