Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Deps update #1294

Merged
merged 19 commits into from
May 30, 2022
Merged

[r2r] Deps update #1294

merged 19 commits into from
May 30, 2022

Conversation

artemii235
Copy link
Member

No description provided.

Artem Vitae added 17 commits May 23, 2022 18:39
WIP. Compilation fails.
56dc18f
WIP.
07beeb0
WIP. Fixed most of the issues.
06ac4e5
Temporary ignore few advisories that can't be fixed fast.
9bc195b
Tried to update Solana-sdk.
c3aad48
WIP. Updated prost-build.
143df75
Checking WASM upload.
1430900
Checking WASM upload.
9c03426
WIP. Trying serde-wasm-bindgen.
8f1495f
WIP. Fixed WASM tests and deps cycle.
cdb6e0c 
By removing serde-serialize wasm-bindgen feature and using serde-wasm-bindgen instead.
Merge remote-tracking branch 'origin/dev' into deps-update
892fe7a
Fix WASM lib compilation.
083a368
Removed some deps. Created wasm module in common. Put de/serialize_to…
d9f4308 
…/from_js there.
Remove commented portfolio crate as it doesn't exist anymore.
af88ac8
Removed some duplicated deps.
88c72a6
Update rustls related stuff. Deny duplicates, but skip existing ones …
5780f72 
…for now.
Remove try_grpc test.
cbf0845
This was referenced May 27, 2022
Closed
Closed
@artemii235 artemii235 added the P0 label May 27, 2022
@artemii235 artemii235 changed the title [wip] Deps update [r2r] Deps update May 27, 2022
sergeyboyko0791
sergeyboyko0791 reviewed May 27, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!
Only a few questions/suggestions

mm2src/coins/solana.rs Outdated Show resolved Hide resolved
mm2src/coins/solana/solana_decode_tx_helpers.rs Outdated Show resolved Hide resolved
mm2src/coins/solana/spl.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/rpc_clients.rs Outdated Show resolved Hide resolved
mm2src/coins/utxo/rpc_clients.rs Outdated Show resolved Hide resolved
mm2src/mm2_db/src/indexed_db/indexed_db.rs Outdated Show resolved Hide resolved
@shamardy shamardy mentioned this pull request May 27, 2022
Merged
shamardy
shamardy previously approved these changes May 27, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one non-blocker comment

mm2src/gossipsub/src/behaviour.rs Outdated Show resolved Hide resolved
onur-ozkan
onur-ozkan reviewed May 28, 2022
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!. Just couple notes 🙂

CONTRIBUTING.md Outdated Show resolved Hide resolved
mm2src/mm2_main/src/ordermatch_tests.rs Outdated Show resolved Hide resolved
onur-ozkan
onur-ozkan reviewed May 28, 2022
View reviewed changes
Cargo.lock Show resolved Hide resolved
@artemii235
Copy link
Member Author

@shamardy @ozkanonur @sergeyboyko0791 Thanks for your notes! I've fixed all of them. The PR is ready for next review iteration :)

onur-ozkan
onur-ozkan approved these changes May 29, 2022
View reviewed changes
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes, great work!

sergeyboyko0791
sergeyboyko0791 approved these changes May 29, 2022
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the changes!

shamardy
shamardy approved these changes May 29, 2022
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-Approve

@artemii235 artemii235 merged commit b61c166 into dev May 30, 2022
@artemii235 artemii235 deleted the deps-update branch May 30, 2022 04:39
@artemii235 artemii235 mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@onur-ozkan onur-ozkan onur-ozkan approved these changes

@shamardy shamardy shamardy approved these changes

Assignees
No one assigned
Labels
P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artemii235 @shamardy @onur-ozkan @sergeyboyko0791