forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nft): enable eth with non fungible tokens #2049
Merged
Merged
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a2b3075
WIP
laruh 750ab10
WIP enable_global_non_fungible_token func in Ops
laruh 5e949c1
impl `global_nft_from_platform_coin`, use Json ref in `enable_platfor…
laruh 9a90130
fix tests
laruh d865452
impl get_nft_activation_result and use url in global_nft_from_platfor…
laruh ca89aa6
impl re_enable_passive_platform_coin_with_nfts
laruh f8138d6
clone some fields from platform to global nft
laruh 498c015
add `EthCoinType::Nft`
laruh c8a0246
fix lint
laruh 87ab779
add NFT in CoinsContext, impl fn update_nft_global_in_coins_ctx
laruh 87d5944
add construct_moralis_uri_for_nft
laruh be71278
more doc comms, move `ParseContractTypeError` to nft_errors.rs
laruh 711651d
remove unnecessary drop_mutability
laruh 52b353a
added `process_transfer_list`, `process_nft_list_for_activation` func…
laruh 7df590f
doc coms for Chain methods, simplify matching in Chain
laruh a9b50de
revert **self
laruh ec2dfb3
doc comm for `non_fungible_tokens_infos` field
laruh 7023761
use `nfts_infos` name
laruh 9acf8cb
rename function to `enable_global_nft`
laruh f6ddd62
delete `enable_eth_with_non_fungible_tokens` RPC, move nft activation…
laruh 39673cb
use enum types in `enable_token` for `EthCoin`
laruh d631564
use `Nft { platform }` for ticker
laruh 24f954d
Merge remote-tracking branch 'origin/dev' into enable-eth-non-fungibl…
laruh 2fb318f
fix merge conflicts
laruh 84f944f
remove doc-comments for the functions arguments
laruh 90d02c4
use optional `global_nft` param in `add_platform_with_tokens`
laruh 0ac2dfd
use `load` to create the same `AtomicU64` for required_confirmations
laruh 59170c6
return `EthTokenActivationError` in `global_nft_from_platform_coin`
laruh 9517082
link Global NFT `abortable_system` to platform coin
laruh 5177505
add NFT support in `coin_conf_with_protocol` function
laruh 0334772
Dont register Nft in platform coin
laruh 9009802
support NFT match type for the enable_token function
laruh b1a6b38
rename mod `erc20_token_activation` to `eth_tokens_activation`
laruh 407a79f
remove unused `get_nft_activation_result` fn and `get_nfts_infos` fn
laruh 9b96e5f
change match errors
laruh 81af437
provide more info about global nft in doc com, match Transport err wi…
laruh 8e6537a
use new idb cursor methods, add more err variants in nft wasm storage
laruh 5379350
provide doc com and note for `update_nft_infos` fnc
laruh af5c356
Merge remote-tracking branch 'origin/dev' into enable-eth-non-fungibl…
laruh 11284b9
more doc comms, simplify `ParseChainTypeError`
laruh c8dff90
move `nfts_map` creation from the beginning of `get_activation_result…
laruh 429cbe2
use `untagged` for `EthTokenInitResult`, add match protocol_conf
laruh 1fee1cf
use `untagged` for `EthTokenActivationParams` and change types order …
laruh 6dd8f31
return Ok(None) in enable_global_nft, remove unused error, use "not s…
laruh 7e98ae1
rollback name changing of erc20_token_activation module
laruh 4d8fc17
Merge remote-tracking branch 'origin/dev' into enable-eth-non-fungibl…
laruh 0769f03
fix merge conflicts
laruh 8fc8d08
refactor NftActivationRequest struct, add NftProviderEnum, match Coin…
laruh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: How exactly we raise
GetNftInfoError::TokenNotFoundInWallet
errors ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we propagate
GetNftInfoError::TokenNotFoundInWallet
error when we try to get nft object from storage.Right now we need to impl From
GetNftInfoError
forEthTokenActivationError
, bcz inglobal_nft_from_platform_coin
function we useget_nfts_for_activation
function, which returnGetNftInfoError
.GetNftInfoError
is an error when we try to get nft from storage/from moralis sources.