feat(nft): enable eth with non fungible tokens #2049

laruh · 2024-01-16T11:02:22Z

This Pull Request introduces the functionality to enable EVM based coin as a platform coin along with its associated Non-Fungible Tokens (NFTs) owned by user.
Also PR includes enable_nft implementation, which works same way as enable_erc20.

Main Features:

enable_eth_with_tokens PRC: now works for both erc20 and nfts activation.
New enable_nft RPC: re utilizes enable_token::<EthCoin> function
NFT update in Coins Context: Ensures that the global NFT within the coins context is updated with the latest NFT information.

…m_coin`

…m_coin

borngraced

Looks great! first iteration focusing on only some codes

mm2src/coins/eth/v2_activation.rs

mm2src/coins/nft/nft_structs.rs

mm2src/coins/nft.rs

mm2src/coins/eth/eth_tests.rs

…s, struct update syntax, deserialize() method

laruh · 2024-01-19T12:31:02Z

linter fails in CI
👀 hmmm I dont have this linter error locally

error[E0434]: can't capture dynamic environment in a fn item
   --> mm2src/coins/eth/v2_activation.rs:322:17
    |
322 |             ..**self
    |                 ^^^^
    |
    = help: use the `|| { ... }` closure form instead

For more information about this error, try `rustc --explain E0434`.
error: could not compile `coins` due to previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.

May be we have different env in CI, will revert this change

shamardy

Thanks a lot for the PR! Only 2 comments at this stage since the first comment will lead to a lot of changes that I would rather review the code after them.

mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs

mm2src/coins/eth/eth_tests.rs

…in this enum.

shamardy

Next review iteration! Still have one more iteration to go as I found this review is growing, please resolve conflicts also, there was a change in the web3 transport interface due to this #2058 .

mm2src/mm2_main/src/lp_swap/check_balance.rs

mm2src/coins_activation/src/tendermint_with_assets_activation.rs

mm2src/coins_activation/src/solana_with_tokens_activation.rs

mm2src/coins_activation/src/bch_with_tokens_activation.rs

mm2src/coins/eth.rs

mm2src/coins/eth/v2_activation.rs

mm2src/coins/nft.rs

shamardy · 2024-02-27T13:19:44Z

mm2src/coins_activation/src/prelude.rs

 #[allow(clippy::result_large_err)]
 pub fn coin_conf_with_protocol<T: TryFromCoinProtocol>(
    ctx: &MmArc,
    coin: &str,
 ) -> Result<(Json, T), MmError<CoinConfWithProtocolError>> {
-    let conf = coin_conf(ctx, coin);
+    let (conf, coin_protocol) = match Chain::from_nft_ticker(coin) {


I think I was a bit wrong in suggesting not adding NFTs in coin configs, if moralis supported more EVM chains or we moved away from moralis for a web3 native implementation (if possible in the future), it would be easier to add new chains and their NFTs in config without requiring a PR in komodefi. I guess one way to do this in the future is to have a field in platform coin configuration for if they support NFT or not, and we enable global NFT using the platform ticker and append NFT_ prefix to it. This is not needed at all for now, but if it was requested in the future we can do it.

…upported yet!". Update CoinsContext inside update_nft_global_in_coins_ctx

…e-tokens # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins_activation/src/erc20_token_activation.rs # mm2src/coins_activation/src/eth_with_token_activation.rs

laruh · 2024-02-27T18:46:10Z

Ive reverted the name of the erc20_token_activation module to minimize conflicts within this module.
Considering the potential for conflicts in other PRs and our uncertainty about whether well continue using the same methods for both eth and nft impls, should we stick with the old name? Alternatively, I could rename it again, perhaps to erc20_nft_token_activation.
@shamardy @onur-ozkan

shamardy · 2024-02-28T19:51:28Z

should we stick with the old name? Alternatively, I could rename it again, perhaps to erc20_nft_token_activation

We can leave the old name for now and rename it later.

shamardy

LGTM! Only a few non-blockers!

mm2src/coins/lp_coins.rs

mm2src/coins/eth/v2_activation.rs

…Protocol::Nft

shamardy · 2024-03-01T02:39:17Z

@laruh can you please provide @KomodoPlatform/qa examples for the new enable_nft RPC. You can provide it here post merge or in the NFT issue #900. @KomodoPlatform/qa I think it would be good to make sure that other NFT RPCs work well with and without activation.

* dev: feat(indexeddb): advanced cursor filtering impl (KomodoPlatform#2066) update dockerhub destination repository (KomodoPlatform#2082) feat(event streaming): configurable worker path, use SharedWorker (KomodoPlatform#2080) fix(hd_tests): fix test_hd_utxo_tx_history unit test (KomodoPlatform#2078) feat(network): improve efficiency of known peers handling (KomodoPlatform#2074) feat(nft): enable eth with non fungible tokens (KomodoPlatform#2049) feat(ETH transport & heartbeats): various enhancements/features (KomodoPlatform#2058)

This commit introduces the functionality to enable EVM based coin as a platform coin along with its associated Non-Fungible Tokens (NFTs) owned by user. It includes enable_nft implementation, which works same way as enable_erc20.

revert botched rebase This reverts commit bc89322.

laruh added 10 commits December 31, 2023 19:44

WIP

a2b3075

WIP enable_global_non_fungible_token func in Ops

750ab10

impl global_nft_from_platform_coin, use Json ref in `enable_platfor…

5e949c1

…m_coin`

fix tests

9a90130

impl get_nft_activation_result and use url in global_nft_from_platfor…

d865452

…m_coin

impl re_enable_passive_platform_coin_with_nfts

ca89aa6

clone some fields from platform to global nft

f8138d6

add EthCoinType::Nft

498c015

fix lint

c8a0246

add NFT in CoinsContext, impl fn update_nft_global_in_coins_ctx

87ab779

laruh added the in progress Changes will be made from the author label Jan 16, 2024

laruh added 2 commits January 17, 2024 20:30

add construct_moralis_uri_for_nft

87d5944

more doc comms, move ParseContractTypeError to nft_errors.rs

be71278

laruh added under review and removed in progress Changes will be made from the author labels Jan 18, 2024

borngraced requested changes Jan 19, 2024

View reviewed changes

remove unnecessary drop_mutability

711651d

laruh added in progress Changes will be made from the author and removed under review labels Jan 19, 2024

laruh added 2 commits January 19, 2024 18:58

added process_transfer_list, process_nft_list_for_activation func…

52b353a

…s, struct update syntax, deserialize() method

doc coms for Chain methods, simplify matching in Chain

7df590f

revert **self

a9b50de

laruh added under review and removed in progress Changes will be made from the author labels Jan 19, 2024

doc comm for non_fungible_tokens_infos field

ec2dfb3

shamardy reviewed Feb 2, 2024

View reviewed changes

mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs Outdated Show resolved Hide resolved

mm2src/coins/eth/eth_tests.rs Outdated Show resolved Hide resolved

laruh added 2 commits February 25, 2024 22:20

use untagged for EthTokenInitResult, add match protocol_conf

429cbe2

use untagged for EthTokenActivationParams and change types order …

1fee1cf

…in this enum.

shamardy reviewed Feb 27, 2024

View reviewed changes

laruh mentioned this pull request Feb 27, 2024

deprecate withdraw_erc721/withdraw_erc1155 and use the global withdraw method #2075

Open

laruh added 2 commits February 27, 2024 22:46

return Ok(None) in enable_global_nft, remove unused error, use "not s…

6dd8f31

…upported yet!". Update CoinsContext inside update_nft_global_in_coins_ctx

rollback name changing of erc20_token_activation module

7e98ae1

laruh force-pushed the enable-eth-non-fungible-tokens branch from 507194a to 7e98ae1 Compare February 27, 2024 16:07

laruh added 2 commits February 27, 2024 23:30

Merge remote-tracking branch 'origin/dev' into enable-eth-non-fungibl…

4d8fc17

…e-tokens # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins_activation/src/erc20_token_activation.rs # mm2src/coins_activation/src/eth_with_token_activation.rs

fix merge conflicts

0769f03

shamardy previously approved these changes Feb 28, 2024

View reviewed changes

mm2src/coins/lp_coins.rs Outdated Show resolved Hide resolved

mm2src/coins/eth/v2_activation.rs Outdated Show resolved Hide resolved

refactor NftActivationRequest struct, add NftProviderEnum, match Coin…

8fc8d08

…Protocol::Nft

laruh dismissed shamardy’s stale review via 8fc8d08 February 29, 2024 09:00

shamardy approved these changes Mar 1, 2024

View reviewed changes

shamardy added 2.1.0-beta QA sec-review docs labels Mar 1, 2024

shamardy merged commit 238a0f2 into dev Mar 1, 2024
28 of 34 checks passed

shamardy deleted the enable-eth-non-fungible-tokens branch March 1, 2024 04:31

Alrighttt added a commit that referenced this pull request Mar 18, 2024

Revert "feat(nft): enable eth with non fungible tokens (#2049)"

0d5a47e

revert botched rebase This reverts commit bc89322.

laruh mentioned this pull request Apr 1, 2024

feat(hd_wallet): evm hd wallet and trezor #1979

Merged

8 tasks

laruh mentioned this pull request May 16, 2024

feat(nft-swap): add standalone maker contract and proxy support #2100

Merged

shamardy mentioned this pull request Aug 1, 2024

chore(release): v2.1.0-beta #2043

Merged

smk762 added docs-under-review and removed docs labels Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nft): enable eth with non fungible tokens #2049

feat(nft): enable eth with non fungible tokens #2049

laruh commented Jan 16, 2024 •

edited

Loading

borngraced left a comment

laruh commented Jan 19, 2024

shamardy left a comment •

edited

Loading

shamardy left a comment

shamardy Feb 27, 2024

laruh commented Feb 27, 2024

shamardy commented Feb 28, 2024

shamardy left a comment

shamardy commented Mar 1, 2024 •

edited

Loading

feat(nft): enable eth with non fungible tokens #2049

feat(nft): enable eth with non fungible tokens #2049

Conversation

laruh commented Jan 16, 2024 • edited Loading

Main Features:

borngraced left a comment

Choose a reason for hiding this comment

laruh commented Jan 19, 2024

shamardy left a comment • edited Loading

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

shamardy Feb 27, 2024

Choose a reason for hiding this comment

laruh commented Feb 27, 2024

shamardy commented Feb 28, 2024

shamardy left a comment

Choose a reason for hiding this comment

shamardy commented Mar 1, 2024 • edited Loading

laruh commented Jan 16, 2024 •

edited

Loading

shamardy left a comment •

edited

Loading

shamardy commented Mar 1, 2024 •

edited

Loading