-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): v2.1.0-beta #2043
Conversation
This commit implements balance events for UTXOs and fixes an electrum notification receiving bug.
…Cs (#2015) This commit does the following: - Implements WASM storage for upgraded swaps. - Implements old swaps data migration. - Swaps kickstart on MM2 reload. - Swaps file lock, preventing the same swap from starting from different processes. - my_swap_status, my_recent_swaps V2 RPCs. - V1 RPCs can also return upgraded swaps data. - Adds BoolAsInt struct because boolean can be used as IndexedDb indexes. - Implements refund states for both swap types. *Important note: - Seednodes should be updated to support/rebroadcast new swap protocol messages.
This commit adds support for witness inputs and outputs for withdraw tx to sign it with trezor device. It also adds a test tool to sign withdraw tx with witness inputs/outputs with trezor and emulator.
This commit implements balance events for ETH plus error events.
This commit does the following: * Adds address builder pattern * Adds `script_type` field to Address structure * Refactors output script creation * Replaces use of u8 addr prefixes to a strict type `NetworkAddressPrefixes`
This commit does the following: * It introduces two new functions, erc1155_balance and erc721_owner, to the EthCoin structure. These enhancements streamline the NFT withdrawal process in the withdraw_nft RPC by directly interacting with smart contracts for validation, eliminating the need to access database information. * It adds a new clear_nft_db RPC for NFT data management. This new method allows users to selectively clear NFT data for specified blockchain networks, or to completely wipe it across all supported chains.
…2046) What's done: - Locked amount handling for UTXO swaps (more work will be needed for ETH/ERC20) - Implemented conditional wait for maker payment confirmation before signing funding tx spend preimage on taker's side. - active_swaps V2 RPC - Handling accept_only_from for swap messages (validation of the sender) - Added swap_uuid for swap v2 messages to avoid reusage of the messages generated for other swaps - Implemented maker payment immediate refund path handling - Implemented KMD dex fee burn for upgraded swaps - Added dockerized Geth node for ETH-related integration tests (more to be done in the next sprints) - Fixed ETH watcher tests Updated deps: - test-containers (other Cargo.lock updates are triggered by it). The purpose is to rely on the official version instead of using the fork. The fork also didn't allow passing additional arguments to the image (only `docker run` options were available).
What effects does the DB changes have? If seed nodes don't save JSON files of swaps any more, then i can't use this on my seeds, else i will destroy all stats. Other question: is there a way to tell mm2 to continue saving swap infos in files, like with a startup param? |
JSON files are not used for v2 swaps only which to be activated currently
We can look into that for v2 swaps before activating it or you can use |
so for v1 swaps, nothing changes? the files will still be there on makers and seeds? i use the files on the seeds to add the swaps to MySQL which feeds different things and on the makers i need them to refund... i need to call this manually from time to time
it looks in all files for "MakerPaymentRefundFailed" and "TakerPaymentSpendFailed" and calls btw, what will we do with the users whose swap files need to be manually edited before refund? will it be possible to edit the stuff in the DB? |
This commit implements the following: - ETH websocket transport. - komodo-defi-proxy signed messages. - expirable hashmap, so that request contexts can be cleaned after timeout. - Refactor web3 contexts, connection rotation and remove singular `web3` field from ETH coin. - Heartbeats implementation for streaming channels. - Refactored node rotation (moved from transport to protocol level, so it can be rotated across different transports) - RPC abstraction for ETH
This commit renames mm2 binaries to kdf while also producing a copy that uses mm2 naming for backward compatibility. For wasm, only kdf named binaries are provided.
) - Run local ATOM testnet in container for integration tests - Run local NUCLEUS testnet in container for integration tests - Add IBC relayer node in container connected to both testnets - Include test coverage for Tendermint - ETH swap - Use .docker/container-state for consistent testnet initial state
* install `paramiko` in CI container Signed-off-by: onur-ozkan <work@onurozkan.dev> * create artifact uploader python script Signed-off-by: onur-ozkan <work@onurozkan.dev> * use in-tree script for uploading artifacts Signed-off-by: onur-ozkan <work@onurozkan.dev> * extend deps-install composite pipeline Signed-off-by: onur-ozkan <work@onurozkan.dev> * apply review notes Signed-off-by: onur-ozkan <work@onurozkan.dev> * apply review note Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
…2155) This commit makes tendermint to use more precise max amount for withdraw operations by removing the estimated fee (by simulating the transaction) from it.
This commit introduces containers runtime directories for dockerized tests to ensure files consistency with each run and prevent local file changes with each test execution.
Extends `common::http_uri_to_ws_address` helper to include address path.
This commit adds macOS target on Apple Silicon. Komodo wallet GUI has a new dependency that is incompatible with x86 architecture on macOS, breaking the current solution of building for x86 and running on Rosetta.
* resolve the expected sequence number locally Signed-off-by: onur-ozkan <work@onurozkan.dev> * drop SWAP locks for tendermint tests Signed-off-by: onur-ozkan <work@onurozkan.dev> * bless clippy Signed-off-by: onur-ozkan <work@onurozkan.dev> * chain regex options Signed-off-by: onur-ozkan <work@onurozkan.dev> * update account sequence error message Signed-off-by: onur-ozkan <work@onurozkan.dev> --------- Signed-off-by: onur-ozkan <work@onurozkan.dev>
This commit introduces the following key changes related to issue #900: - Implement standalone NFT maker swap contract (EtomicSwapMakerNftV2) - Add komodefi-proxy support for NFT feature, enabling HTTP GET requests Additional changes include: - Implement Multi Standalone Etomic Swap contracts approach - Add support for EtomicSwapTakerV2 contract - Enhance security with checks for malicious token_uri links - Make clear_all parameter optional in clear_nft_db RPC (default: false) - Implement Sepolia testnet support for testing This change adopts the new Etomic swap implementation approach as discussed in KomodoPlatform/etomic-swap#7 (comment)
Sorry for the late response @cipig, For v2, you can call
Will add it to the trading protocol upgrade checklist #1895 (comment) Maybe we can add an rpc to let you edit swap data / events in DB. We shouldn't need to manually edit swap data but sometimes it's inevitable. |
Only if |
It does for both v1 and v2 swaps https://komodoplatform.com/en/docs/komodo-defi-framework/api/legacy/my_recent_swaps/#response-success , we can even add filters for specific events in the future to make life easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No critical defects found in testing. Docs updates in progress, should be aligned by end of week
…in (#2184) This commit creates new `sign_low_r` function and keeps using regular sign for `derive_htlc_key_pair` of zcoin
Features:
get_mnemonic
API. #2014sign_raw_transaction
rpc was added for UTXO and EVM coins, this will facilitate air-gapped wallet implementation in the future. #1930Enhancements/Fixes:
my_swap_status
,my_recent_swaps
V2 RPCs introduced. #2015active_swaps
V2 RPC introduced. #2046accept_only_from
for swap messages (validation of the sender) was implemented. #2046swap_uuid
for swap v2 messages was added to avoid reuse of the messages generated for other swaps. #2046clear_nft_db
RPC for NFT data management was added. This enables selective (based on a chain) or complete NFT DB data clearance. #2039enable_eth_with_tokens
orenable_nft
, similar toenable_erc20
. #2049komodo-defi-proxy
support for NFT feature was added. #2100token_uri
links. #2100clear_all
parameter inclear_nft_db
RPC is now optional (default:false
). #2100event_stream_configuration
with a default toevent_streaming_worker.js
. #2080testcoin
was added to provider options to allow testing the maker bot using test chains assets. #2161where_
condition/option. #2066stats_swaps
table now includes GUI and MM2 version data used for a swap. #2061max_concurrent_connections
to MM2 config to control the maximum number of concurrent connections for Gossipsub. #2063first_sync_block
handling. #2089komodo-defi-proxy
signed messages were also supported for websocket transport. #2058get_receiver_trade_fee
in platform coin. #2106ibc_withdraw
RPC was removed, andwithdraw
was refactored to support IBC transfers by automatically finding IBC channels. #2088gas_limit
parameter can be used in coins config to override default gas limit values. #2137gas_limit
values now ensure that Proxied ERC20 tokens have sufficient gas. #2137KAWPOW
version headers. #2099.kdf
under$HOME
to consolidate all runtime files, enhancing user experience by following standard UNIX practices. #2102.tmp
files to avoid concurrent reading/writing issues. #2118wallet-only
restriction was removed frommax_maker_vol
RPC, enabling its use for wallet-only mode assets. #2153NB - Backwards compatibility breaking changes:
mm2
binaries tokdf
, while providing backward-compatible copies withmm2
naming; WASM binaries usekdf
naming only, which is a breaking change. #2126