refactor(memory): memory usage improvements #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
changed the title
String to improve memory usage in foldingString
onur-ozkan
changed the title
String
onur-ozkan
added
in progress
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
preallocated-fold
branch
6 times, most recently
from
ae75a3b
to
7b041d6
Compare
onur-ozkan
added
micro-opt
|
@onur-ozkan please fix conflicts in this PR so that I can approve it. |
… into keplr-and-external-sign-swap
onur-ozkan
force-pushed
the
preallocated-fold
branch
from
49d7d3c
to
a806b48
Compare
Done. |
shamardy
approved these changes
May 7, 2024
|
Hi @onur-ozkan curious to learn the advantage of calling I assume you're trying to avoid calling |
Makes it easier for compiler to optimize (as it stays immutable explicitly) the memory usage. |
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 9, 2024
* dev: fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115) fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114) refactor(memory): memory usage improvements (KomodoPlatform#2098)
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 14, 2024
* dev: feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088) fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116) fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115) fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114) refactor(memory): memory usage improvements (KomodoPlatform#2098) feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102) fix tendermint fee calculation (KomodoPlatform#2106) update dockerfile (KomodoPlatform#2104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self-explanatory