Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utxo-swap): apply events occurred while taker down #2114

Merged
merged 4 commits into from
May 7, 2024

Conversation

dimxy
Copy link
Collaborator

@dimxy dimxy commented May 7, 2024

Fix missed apply_event for events discovered while taker was offline, like the maker spent or watcher refunded the taker payment.
Closes this #2111

@dimxy dimxy added in progress Changes will be made from the author under review and removed under review in progress Changes will be made from the author labels May 7, 2024
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for finding the cause of this error and fixing it :)

@shamardy shamardy merged commit 9a82349 into dev May 7, 2024
26 of 30 checks passed
@shamardy shamardy deleted the fix-apply-events branch May 7, 2024 14:39
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 9, 2024
* dev:
  fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115)
  fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114)
  refactor(memory): memory usage improvements (KomodoPlatform#2098)
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 14, 2024
* dev:
  feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088)
  fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116)
  fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115)
  fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114)
  refactor(memory): memory usage improvements (KomodoPlatform#2098)
  feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102)
  fix tendermint fee calculation (KomodoPlatform#2106)
  update dockerfile (KomodoPlatform#2104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants