Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-dir): implement root application dir .kdf #2102

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Apr 25, 2024

Consolidates all the runtime files together under $HOME/.kdf by default (so you don't have to set environment variables on the host). This should improve the user experience significantly as this is a standard practice followed by most of the programs on UNIX systems.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan onur-ozkan added enhancement New feature or request under review labels Apr 25, 2024
@onur-ozkan
Copy link
Member Author

onur-ozkan commented Apr 25, 2024

I am aware for the WASM problem, will fix it.

@onur-ozkan onur-ozkan added in progress Changes will be made from the author under review and removed under review in progress Changes will be made from the author labels Apr 25, 2024
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! just a suggestion and question

mm2src/common/common.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/src/mm2.rs Show resolved Hide resolved
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this much needed fix/enhancement!

@shamardy shamardy merged commit a0d8723 into dev May 6, 2024
17 of 25 checks passed
@shamardy shamardy deleted the feat-app-dir branch May 6, 2024 13:46
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 9, 2024
* dev:
  feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102)
  fix tendermint fee calculation (KomodoPlatform#2106)
  update dockerfile (KomodoPlatform#2104)
  docs(README): remove outdated information from the README (KomodoPlatform#2097)
  fix(sia): fix sia compilation after hd wallet PR merge (KomodoPlatform#2103)
  feat(hd_wallet): utxo and evm hd wallet and trezor (KomodoPlatform#1962)
  feat(sia): initial Sia integration (KomodoPlatform#2086)
  fix(BCH): deserialize BCH header that uses KAWPOW version correctly (KomodoPlatform#2099)
  fix(eth_tests): remove ETH_DEV_NODE from tests (KomodoPlatform#2101)
  feat(coin): support nucleus as an alternative to iris HTLC (KomodoPlatform#2079)
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 14, 2024
* dev:
  feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088)
  fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116)
  fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115)
  fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114)
  refactor(memory): memory usage improvements (KomodoPlatform#2098)
  feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102)
  fix tendermint fee calculation (KomodoPlatform#2106)
  update dockerfile (KomodoPlatform#2104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants