feat(sia): initial Sia integration #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
reviewed
Mar 12, 2024
There was a problem hiding this comment.
Looks like a great start :)
No major issues at all so I just left some comments that I am sure you are aware of, but I am leaving them just in case. Don't forget doc comments on pub structs/enums/functions/traits/etc.. please also try to fix merge conflicts quickly before they get too much. I guess the next step would be deriving address from pubkey.
|
All review comments addressed. Thanks for the feedback. |
shamardy
reviewed
Apr 25, 2024
shamardy
approved these changes
Apr 25, 2024
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Apr 29, 2024
* dev: docs(README): remove outdated information from the README (KomodoPlatform#2097) fix(sia): fix sia compilation after hd wallet PR merge (KomodoPlatform#2103) feat(hd_wallet): utxo and evm hd wallet and trezor (KomodoPlatform#1962) feat(sia): initial Sia integration (KomodoPlatform#2086) fix(BCH): deserialize BCH header that uses KAWPOW version correctly (KomodoPlatform#2099) fix(eth_tests): remove ETH_DEV_NODE from tests (KomodoPlatform#2101)
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 9, 2024
* dev: feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102) fix tendermint fee calculation (KomodoPlatform#2106) update dockerfile (KomodoPlatform#2104) docs(README): remove outdated information from the README (KomodoPlatform#2097) fix(sia): fix sia compilation after hd wallet PR merge (KomodoPlatform#2103) feat(hd_wallet): utxo and evm hd wallet and trezor (KomodoPlatform#1962) feat(sia): initial Sia integration (KomodoPlatform#2086) fix(BCH): deserialize BCH header that uses KAWPOW version correctly (KomodoPlatform#2099) fix(eth_tests): remove ETH_DEV_NODE from tests (KomodoPlatform#2101) feat(coin): support nucleus as an alternative to iris HTLC (KomodoPlatform#2079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added skeleton Sia integration to demonstrate the code organization.
Mocked the minimal amount of functionality to support enabling a "sia protocol" coin
PoC of HTTP(s) interface between mm2 and Sia's walletd node software
Implemented 2 walletd endpoints, GET
api/consensus/tipand GETapi/addresses/<address>/balanceConditional compilation of all sia features
Planned for next sprint:
Add config option for HTTP timeout
Implement sensitization of
let endpoint_path = format!("api/addresses/{}/balance", address);or similar patterns.Re-enable docker unit tests