feat(coin): support nucleus as an alternative to iris HTLC #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
added
enhancement
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
f28ac02
to
fb90aa1
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
3d211f1
to
d1de38f
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
|
This is almost ready to be reviewed/merged, with just a couple of tests needing to be updated. I will take care of this once the explorer is ready for Nucleus. |
onur-ozkan
added
under review
and removed
in progress
shamardy
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Thank you for the PR! Please add doc comments to new files and also fix wasm tests!
I guess once tests are updated ref here #2079 (comment) this PR can be approved and merged.
5 tasks
… into nucleus-support Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
6513f11
to
b5e85b9
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
e34595a
to
6c14ebb
Compare
|
This is ready to go. cc @shamardy |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
b29161e
to
63c953a
Compare
Signed-off-by: onur-ozkan <work@onurozkan.dev>
shamardy
previously approved these changes
Apr 18, 2024
| @@ -1075,7 +1075,7 @@ fn test_withdraw_and_send_hd() { | |||
| const TX_HISTORY: bool = false; | |||
| const PASSPHRASE: &str = "tank abandon bind salon remove wisdom net size aspect direct source fossil"; | |||
|
|
|||
| let coins = json!([rick_conf(), tbtc_segwit_conf()]); | |||
| let coins = json!([rick_conf(), tbtc_segwit_conf(), eth_testnet_conf()]); | |||
There was a problem hiding this comment.
This doesn't have eth_testnet_conf() in dev, looks like a problem due to merging.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
nucleus-support
branch
from
f170bc9
to
1b824b0
Compare
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
May 9, 2024
* dev: feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102) fix tendermint fee calculation (KomodoPlatform#2106) update dockerfile (KomodoPlatform#2104) docs(README): remove outdated information from the README (KomodoPlatform#2097) fix(sia): fix sia compilation after hd wallet PR merge (KomodoPlatform#2103) feat(hd_wallet): utxo and evm hd wallet and trezor (KomodoPlatform#1962) feat(sia): initial Sia integration (KomodoPlatform#2086) fix(BCH): deserialize BCH header that uses KAWPOW version correctly (KomodoPlatform#2099) fix(eth_tests): remove ETH_DEV_NODE from tests (KomodoPlatform#2101) feat(coin): support nucleus as an alternative to iris HTLC (KomodoPlatform#2079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements nucleus chain into mm2 providing an alternative HTLC backend to Iris.