Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zcoin): syncing and activation improvements #2089

Merged
merged 5 commits into from
Apr 9, 2024
Merged

fix(zcoin): syncing and activation improvements #2089

merged 5 commits into from
Apr 9, 2024

Conversation

borngraced
Copy link
Member

@borngraced borngraced commented Mar 19, 2024 •
edited
Loading

  • Stop sending sync status after main sync state (main improvement)
  • Remove first_sync_block from SyncStatus and stop sending first_sync_block while activation is in progress
  • include first_sync_block in Activation Result only after activation is completed

closes: #2022

@borngraced borngraced self-assigned this Mar 19, 2024
@borngraced borngraced linked an issue Mar 19, 2024 that may be closed by this pull request
stop sending sync status after first/main sync status is finished #2022
Closed
@shamardy shamardy self-requested a review March 22, 2024 22:04
@borngraced borngraced changed the title enhancement(zcoin): minor improvements and enhancement to syncing and activation enhancement(zcoin): improvements and enhancement to syncing and activation Apr 4, 2024
shamardy
shamardy reviewed Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! only one comment!
BTW, the GUI currently has to poll the task status API every few seconds to get the sync status, in the future we will use streaming events for this instead and we wouldn't need to stop sending sync status in the streaming events, we will probably send an event to indicate that initial sync is done but keep sending new blocks, transactions etc..

mm2src/coins/z_coin/z_rpc.rs Outdated Show resolved Hide resolved
@shamardy shamardy changed the title enhancement(zcoin): improvements and enhancement to syncing and activation enhancement(zcoin): syncing and activation improvements Apr 9, 2024
@shamardy shamardy changed the title enhancement(zcoin): syncing and activation improvements fix(zcoin): syncing and activation improvements Apr 9, 2024
@shamardy shamardy merged commit 92199d8 into dev Apr 9, 2024
23 of 35 checks passed
@shamardy shamardy deleted the improve_z_activation branch April 9, 2024 02:33
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request Apr 9, 2024
@dimxy
Merge branch 'dev' into eip1559-gas-fee-estimate
d59387c 
* dev:
  feat(nft-swap): nft swap protocol v2 POC (KomodoPlatform#2084)
  fix(zcoin): syncing and activation improvements (KomodoPlatform#2089)
  feat(crypto): mnemonic generation/encryption/decryption/storage (KomodoPlatform#2014)
  fix(eth): error handling in RPCs (KomodoPlatform#2090)
This was referenced Jul 24, 2024
Open
Closed
@shamardy shamardy mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamardy shamardy shamardy approved these changes

Assignees

@borngraced borngraced

Labels
2.1.0-beta no-deps sec-review under review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop sending sync status after first/main sync status is finished
2 participants
@borngraced @shamardy