feat(nft-swap): add standalone maker contract and proxy support

[laruh]

related to issue #900

Etomic swap implementation approach was changed to Multi Standalone Etomic Swap contracts (see KomodoPlatform/etomic-swap#7 (comment))

At the first stage we are going to support EtomicSwapMakerNftV2 and EtomicSwapTakerV2 contracts in NFT Swap Komodefi feature, where Maker is NFT owner and Taker swaps ETH/ETH20.

• The part related to standalone Maker Nft swap contract is r2r
• Additionally, this commit ebac6e6 contains additional checks for malicious token_uri links like this

https://docs.moralis.io/web3-data-api/evm/reference/get-wallet-nfts?address=0xf622a6C52C94b500542E2AE6bcAD24C53Bc5b6a2&chain=polygon&format=decimal&token_addresses=[]&media_items=false

https://en.wikipedia.org/wiki/Zip_bomb

• In the same commit ebac6e6 clear_all param in clear_nft_db RPC now is optional. false is default.

curl --url "http://127.0.0.1:7783" --data '{"userpass":"'$USERPASS'","method":"clear_nft_db","mmrpc":"2.0","params":{"chains":["POLYGON","BSC"]}}'

• added komodefi-proxy support for nft feature. actually it can be used by any other EVM based feature if it needs to send Http Get requests (ps currently porxy supports only JsonRpc Method calls for EVM). Http Get support for NFT feature komodo-defi-proxy#22

Req/Res examples for enable eth with tokens RPC

If we want to add support of other block chain types, we will need to make SignOps more generic, right now it focuses on eth types https://github.com/KomodoPlatform/komodo-defi-proxy/blob/80d92fbe1714c5052628b80d90c5a994640e3762/src/security/sign.rs#L5

use ethereum_types::{Address, H256};
use ethkey::{sign, verify_address, Secret, Signature};

we will implement this as needed.

[shamardy]

Great work! Only non-blocker comments.
@mariocynicys @onur-ozkan can you please check if your comments are resolved and if you have any more comments.
@laruh I guess I will have to review, approve and then merge this PR #2129 first and also this PR KomodoPlatform/komodo-defi-proxy#22 before merging this. Is that correct?

[shamardy]

We shouldn't use println in tests, we should use log! macro instead

[laruh]

agree, fixed here e672485

[shamardy]

Same with println

[laruh]

done e672485

[laruh]

@laruh I guess I will have to review, approve and then merge this PR #2129 first and also this PR KomodoPlatform/komodo-defi-proxy#22 before merging this. Is that correct?

@shamardy
I think this #2100 PR can be merged in dev first, before #2129 if I dont have review notes which require me to refactor the whole architecture. Then I would prefer to do such big changes in #2129 (to avoid conflicts and messed up logic). In this case, yes we have to merge #2129 to #2100 and then #2100 to dev. If #2100 approved with non-blocker changes like your note, then I can do the changes right in this branch and merge it to #2129.

as for proxy PRs. I have two:

• Http Get support for NFT feature komodo-defi-proxy#22 this branch uses this feature actually
• and this, related to Quicknode refactoring refactor quicknode: move SignedMessage to Header komodo-defi-proxy#23
  feat(nft-swap): complete refund methods #2129 PR supports Quicknode changes in Proxy layer. You can check it in PRs description.

To sum up:
So if #2100 is approved without breaking changes for #2129 branch, then we can merge it to dev, and I will change merge branch to dev in #2129.

Proxies PRs:
#2100 uses this feature KomodoPlatform/komodo-defi-proxy#22
#2129 additionally started to use this pr quicknode refactoring KomodoPlatform/komodo-defi-proxy#23

If #2100 will be fully approved, then it means that reviewers agreed with KomodoPlatform/komodo-defi-proxy#22 logic, same for #2129 and KomodoPlatform/komodo-defi-proxy#23

Proxy prs can get more non braking notes after komodefi being approved, but if reviewers decide to change the format of request to Proxy layer, then we have to update komodefi nft opened prs, or open new if previous were merged

[laruh]

reqs examples how to enable nft, with platform coin and separately

curl --url "http://127.0.0.1:7783" --data '{
  "userpass": "'$USERPASS'",
  "method": "enable_eth_with_tokens",
  "mmrpc": "2.0",
  "params": {
    "ticker": "MATIC",
    "mm2": 1,
    "swap_contract_address": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "maker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "taker_swap_v2_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "fallback_swap_contract": "0x9130b257D37A52E52F21054c4DA3450c72f595CE",
    "nodes": [
      {
        "url": "https://polygon-rpc.com"
      }
    ],
    "erc20_tokens_requests": [],
    "nft_req": {
      "provider":{
        "type": "Moralis",
        "info": {
          "url":"http://localhost:6150/nft-test",
          "proxy_auth":true
        }
      }
    }
  }
}'

curl --url "http://127.0.0.1:7783" --data '{
  "userpass": "'$USERPASS'",
  "method": "enable_nft",
  "mmrpc": "2.0",
  "params": {
    "ticker": "NFT_MATIC",
    "activation_params": {
      "provider":{
        "type": "Moralis",
        "info": {
          "url":"http://localhost:6150/nft-test",
          "proxy_auth":true
        }
      }
    }
  }
}'

[shamardy]

@laruh please fix merge conflicts so that I can give this one final look then approve and merge. I guess NFT will still work if we don't deploy komodefi proxy latest code, right? Also, since docs and coin config PRs are open, I can merge this PR without waiting for QA, unless some testing using new proxy code or for new enable method is needed first c.c. @KomodoPlatform/qa

[laruh]

@shamardy thanks for pinging, will fix conflicts asap. i suppose they occurred after eth gas limit PR merge this night.

I guess NFT will still work if we don't deploy komodefi proxy latest code, right?

NFT feature should work in both cases: if latest komo proxy code deployed or not deployed. as currently https://moralis-proxy.komodo.earth endpoint doesnt have proxy limits, this url can be used with proxy_auth: false (this field even can be skipped in RPC as we use serde default annotation)

I would say its more about not merging this the second nft pr #2129 to dev, as it contains Quicknode http request changes:

without the up to date proxy version quicknode gui_auth:true wont work

I can merge this PR without waiting for QA, unless some testing using new proxy code or for new enable method is needed first

Yes, I suppose this standalone nft pr could be merged to dev now, while the second nft pr with refund methods, v2 activation and Quicknode changes should be merged after @KomodoPlatform/qa team testing and docs, coins pr approve.

[shamardy]

Re-approve