add ibc withdraw method #284
Conversation
|
Preview for merge commit: 543bc93, available on cloudflare at: https://0f9b4a2c.komodo-docs.pages.dev/en/docs/ |
…nks, formatted md content, checked presence of file and dirs based on sidebar, checked presence of h1 in every file, update Komodo DeFi Framework methods table, adds/updates preview images when base is main
|
Preview for merge commit: b8ab087, available on cloudflare at: https://ef1b6bde.komodo-docs.pages.dev/en/docs/ |
github-actions
bot
requested a deployment
to
komodo-docs (Preview)
|
Preview for merge commit: 9a4e739, available on cloudflare at: https://f1cb7375.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 610011d, available on cloudflare at: https://9ca728bb.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: b72a5e0, available on cloudflare at: https://e047cc43.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 1e3768f, available on cloudflare at: https://f77a3b23.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 2f580c6, available on cloudflare at: https://dbc36729.komodo-docs.pages.dev/en/docs/ |
src/pages/komodo-wallet/index.mdx
Outdated
There was a problem hiding this comment.
I'm assuming these are meant to be links. They are not formatted correct. Correct format should be:
[label](link)
There was a problem hiding this comment.
@gcharang not sure what's happening here, but when running run_tests.sh, the links on this page change to insert a \ between the (text) and [link].
There was a problem hiding this comment.
Update, reason found #374 (comment) 🤦
There was a problem hiding this comment.
This page is the index page for the Komodo Wallet Web guides (at least according to the page hierarchy in the left panel navigation). If this is meant to apply to General Komodo Wallet guides, should we not put this in a different page folder on a higher level than the Komodo Wallet guides for the various platforms?
There was a problem hiding this comment.
Please open an issue for this, as it is unrelated to this PR
There was a problem hiding this comment.
I think this may actually be a problem with this PR. This preview contains 2 User Guides (Web) links in the folder hierarchy in the side panel, and both are expanded when 1 is clicked:
 |
 |
This doesn't seem to be an issue on the current user guide pages.
I think the IBC guides will need their own parent entry.
There was a problem hiding this comment.
thanks, feels like a merge fail. I'll have a look
There was a problem hiding this comment.
This should be fixed now
|
@onur-ozkan can you please give this another review if there is anything left? |
|
Preview for merge commit: ff34aae, available on cloudflare at: https://ba3a93f3.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: 92337a6, available on cloudflare at: https://7981a20e.komodo-docs.pages.dev/en/docs/ |
|
Preview for merge commit: a4b2a10, available on cloudflare at: https://66da9862.komodo-docs.pages.dev/en/docs/ |
smk762
requested review from
ShantanuSharma9873
and removed request for
harsenyan3
|
Preview for merge commit: eebb9f3, available on cloudflare at: https://7b1c30d3.komodo-docs.pages.dev/en/docs/ |
closes #283
I had this commit unpushed from earlier, so not 100% sure it is complete. Please advise if any issue while testing, or if you notice anything missing.