Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/kdf/active swaps v2 #374

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Add/kdf/active swaps v2 #374

wants to merge 5 commits into from

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Nov 3, 2024

Closes #281

Copy link

github-actions bot commented Nov 3, 2024

Preview for merge commit: 076046e, available on cloudflare at: https://1f7503fb.komodo-docs.pages.dev/en/docs/

The `active_swaps` method returns all the swaps that are currently running on the Komodo DeFi Framework API node.

<Note>
This method has been deprecated in favor of (active\_swaps v2)\[/komodo-defi-framework/api/v20/active\_swaps]. The legacy version does not include v2 (Trading Protocol Upgrade) swap statuses in responses (it only returns uuids for these).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your linking brackets are being escaped here. So on the front-end the link isn't working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the updates seem to be all in order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, found the cause of this being ()[] wehere it should be [](). There were a couple other instance of this in the repo which have now also been fixed in this PR.

Copy link

Preview for merge commit: e43428a, available on cloudflare at: https://2cc78fc7.komodo-docs.pages.dev/en/docs/

Copy link

Preview for merge commit: f17c4ae, available on cloudflare at: https://6cc7f59c.komodo-docs.pages.dev/en/docs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants