Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.2 Release Candidate #29

Merged
merged 24 commits into from
Jan 15, 2025
Merged

v0.8.2 Release Candidate #29

merged 24 commits into from
Jan 15, 2025

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Jan 13, 2025

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial round of testing has highlighted a couple issues as follows:

  • The Update Notification issue is not resolved. The popup shows every time the application is launched. And I reckon the design of the popup should be altered. If the app is indeed still searching for an update, display the four dots with "searching new updates" text. If already up to date, remove the dots and update the text to say "Your apoplication is up to date!". This is to prevent the user thinking it is still searching.
    image

  • The highlight over the menu options is not aligned with the text. It is particularly bad when "Address Book" is seleted.
    imageimage

  • When hovering on the dex icon, it still lights up, which should probably be removed if it is disabled.
    image

  • The tooltip that is displayed when hovering on DEX is great, but the link cannot be clicked on or copied. Perhaps we should make it such that clicking on DEX opens up the link to the post?
    image

@smk762 smk762 mentioned this pull request Jan 13, 2025
@smk762 smk762 requested a review from AndrewDelaney January 14, 2025 13:59
Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to be working as expected now!

Copy link
Collaborator

@ShantanuSharma9873 ShantanuSharma9873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems proper now.

  • The Highlighting issue reported by @AndrewDelaney is now fixed, gets proper highlighting on tab.
  • A simple text 'DEX is temporarily disabled' is displayed as a tool tip on hovering over the DEX tab.
  • DEX is disabled from the application, and have no access to get into it.
  • Able to Add and disable the coins without any issues.
  • The application version is '0.8.2-beta' at the Version > Settings
  • The languages, themes, , Font type, Fiat all are functional properly.

One thing observed was, at the (User Interface > Settings) the 'Show orders after placement' button is displayed and I guess it should be removed as the DEX is also temporarily disabled.
image

@smk762 smk762 mentioned this pull request Jan 15, 2025
@smk762 smk762 merged commit ef2ef07 into master Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants