Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc review fixes #30

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Rc review fixes #30

merged 5 commits into from
Jan 14, 2025

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Jan 13, 2025

Addresses review feedback from #29 (review)

@smk762 smk762 requested a review from AndrewDelaney January 13, 2025 14:21
Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update notification popup is still displayed whenever I open the application

@smk762
Copy link
Contributor Author

smk762 commented Jan 14, 2025

The update notification popup is still displayed whenever I open the application

This should be functional now.

Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected now, thanks!

@smk762 smk762 merged commit 6a841f9 into dev Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants