Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C++ Test for Simple Work Groups Example #117

Closed
axsaucedo opened this issue Jan 18, 2021 · 1 comment
Closed

Add C++ Test for Simple Work Groups Example #117

axsaucedo opened this issue Jan 18, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@axsaucedo
Copy link
Member

Recently #116 fixed a bug in OpAlgoBase to enable work groups which impeded the feautre to be used. A Python test was added to ensure that workgroups perform as expected:
https://github.com/EthicalML/vulkan-kompute/pull/116/files#diff-6e5055322f539aab58a242b92450beb2a97fc848f40ba9613ab5d720cff8a88bR116

This issue encompasses adding a C++ test that ensures the core feature of workgroups performs as expected in the OpAlgoBase implementation.
@axsaucedo axsaucedo added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2021
@axsaucedo
Copy link
Member Author

Added via #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axsaucedo