-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for custom SpecializedConstants and removed KomputeWorkgroup class #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…removed all string related functions
axsaucedo
changed the title
Added support for custom SpecializedConstants
Added support for custom SpecializedConstants and removed KomputeWorkgroup class
Feb 17, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Outstanding:
After further exploration around other examples online that show how people use specialization constants (and even push constants) it's quite common for users to have mainly unit32_t and float, however for the initial implementation it may be easier to just limit users to input float values. This would also be possible to explore via #2, however it seems there hasn't really been much request for uint32_t, given that most of the use-cases are for compute it seems that float would be appropriate. One thing to explore is the performance impact for users that want to do float to int convesion inside shaders.
For explicitness this is the previous implementation that would've initially allowed for floats and ints, but also coudl've extended to more complex types https://github.com/EthicalML/vulkan-kompute/blob/7126cc47ffeb9770661447689763a2d602824ae6/src/include/kompute/Algorithm.hpp#L17-L112
Done - I have added python bindings and removed the string functions
Done - I added tests for constants and workgroups
This is now done, the refactor simplified to just floats, and now there is kp::Constants and kp::Workgroup