Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple types for Kompute Tensors #2

Closed
axsaucedo opened this issue Aug 28, 2020 · 2 comments · Fixed by #177
Closed

Support multiple types for Kompute Tensors #2

axsaucedo opened this issue Aug 28, 2020 · 2 comments · Fixed by #177
Labels
enhancement New feature or request triage Issue still needs to be discussed, researched and scoped

Comments

@axsaucedo
Copy link
Member

Currently only uint32_t is supported but looking to support further types. This will also require evaluating how these are managed by "Algorithms" and "ParameterGroups"

@axsaucedo axsaucedo added enhancement New feature or request triage Issue still needs to be discussed, researched and scoped labels Aug 28, 2020
@axsaucedo
Copy link
Member Author

Currently refactored to make float the default - needs further exploration on best way to provide typing. The options are to make the Tensor a template, or to add the type as a member variables. It will be important to assess the advantages/disadvantages of each.

@axsaucedo
Copy link
Member Author

@alexander-g I was looking that the vkjax does seem to somewhat support multiple dtypes, and I was currently assessing whether it would be worth adding the ability to support multiple types, for the Kompute tensors - is this something that would add a significant amount of value? Or would it be the case that most scientific compute can be done primarily through float32 types throughout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Issue still needs to be discussed, researched and scoped
Projects
None yet
1 participant