-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bool, double, int32, uint32 and float32 on Tensors via TensorT #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
force-pushed
the
add_tensor_types
branch
from
March 7, 2021 10:42
feb94dc
to
cc1a6cc
Compare
Looks good. |
… different types on tensor
axsaucedo
force-pushed
the
add_tensor_types
branch
from
March 7, 2021 14:13
2972f8b
to
6fd19b9
Compare
axsaucedo
changed the title
Add support for bool, double, int32, uint32 and float32 on Tensors via TensorView
Add support for bool, double, int32, uint32 and float32 on Tensors via TensorT
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Fixes #144
This PR explores the approaches that could be introduced to support multiple types for tensors - it includes:
Tensor
class as just a high level container that doesn't store memoryTensorT
class implementation that introduces abstraction to provide data in CPU with std::vectorTensor
class without any modificationsFurther points to explore:
mData
parameter as discussed in Explore removingstd::vector mData;
completely from Tensor in favour of always storing data in hostVisible buffer memory (TBC) #144 in favour of memory copy on readspan
to avoid passing around pointer memory sizeOther things to explore in separate issue / pr: