-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workgroups for Python #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alexander-g ! Added a couple of comments
a6e4741
to
32f5bb8
Compare
By the way, work group is optional but you might consider making it a required argument because the default is a poor choice. It creates a work group for each value of the first tensor which is usually very inefficient. Instead one should choose a low number of work groups and increase the number of threads per work group e.g. in GLSL: |
Hmmm that is a good point @alexander-g. I think the default is primarily to enable less experienced users to get started with the simpler examples, but I agree that most times in produciton you'd expect people to explicitly provide these. |
Sequence.record_algo*
+ test caseTensor
constructors and it now also accepts numpy arrays