chore(ci): added docker security scan and a linter #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hutchic
commented
Sep 1, 2021
gszr
approved these changes
Sep 1, 2021
|
|
||
| if [[ ! -z "${SNYK_SCAN_TOKEN}" ]]; then |
There was a problem hiding this comment.
checking: is the token added to CI?
Tieske
reviewed
Sep 2, 2021
rhel/Dockerfile
Outdated
| @@ -1,9 +1,7 @@ | |||
| ARG RHEL_VERSION=8 | |||
| ARG RHEL_VERSION=7 | |||
There was a problem hiding this comment.
yeah I upgraded as part of the PR and that broke tests. There were no security issues in 7 so going to keep us pinned there for now
hutchic
commented
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added hadolint with a few exceptions
added the docker snyk security scan feature with exceptions
the community is beginning to sway towards it being acceptable to do upgrades in images