Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not installing security updates is bad advice #614

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

itamarst
Copy link
Contributor

@itamarst itamarst commented Mar 24, 2021

This is obviously bad advice: security updates are important, and should be installed.

For more detailed explanation of why installing security updates in Docker builds is a good idea (I still can't believe I have to write this sentence, or had to write this article...), see https://pythonspeed.com/articles/security-updates-in-docker/

This is obviously bad advice: security updates are important, and should be installed.

For more detailed explanation of why advice against this is bad, see https://pythonspeed.com/articles/security-updates-in-docker/
@jmanico jmanico merged commit 6374632 into OWASP:master Mar 24, 2021
@jmanico
Copy link
Member

jmanico commented Mar 24, 2021

Good call, what a scary mistake on our end, my apologies

@itamarst
Copy link
Contributor Author

Thank you!

@chadlwilson
Copy link

Thanks for this @itamarst - couldn't agree more. Technically the line Ensure the OS packages versions are pinned is potentially contradictory too; depending on how you construct your Dockerfile and order of install vs upgrade.

A number of (all?) distros only allow pinning to a specific build rather than allowing ~ major.minor expressions; which would have the same effect of preventing patches for security to come through, to my knowledge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants