-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add KIC v2.0.x #3099
feat: add KIC v2.0.x #3099
Conversation
✔️ Deploy Preview for kongdocs ready! 🔨 Explore the source changes: c2b7a94 🔍 Inspect the deploy log: https://app.netlify.com/sites/kongdocs/deploys/614b79555bede80007f26d91 😎 Browse the preview: https://deploy-preview-3099--kongdocs.netlify.app |
TBA: waiting for branch deploy URL, will replace the autogenerated one when that's done. And done: https://kic-v2-beta--kongdocs.netlify.app/kubernetes-ingress-controller/ |
This is definitely the way to go.
Working on it. We don't have a structure for this, so we're figuring it out as we go. |
@rainest @shaneutt added labels/metadata to the version dropdown and a banner for the 2.0.x docs in 2694597: I've also set up a redirect from https://docs.konghq.com/kubernetes-ingress-controller-beta to this Netlify preview. Shane C asked that we distribute this URL so that we can track clicks. Can you add this link anywhere that might be useful for users testing the beta? Might be good to put it in the KIC repo README temporarily, or the changelog, etc. |
Thank you @lena-larionova!
|
…he prometheus reference
Update the RBAC resource version in KIC docs to v1 from v1beta1. v1beta1 is unavailable as of Kubernetes 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
Changed the admission webhook configuration API version to "admissionregistration.k8s.io/v1" from "admissionregistration.k8s.io/v1beta1". This breaks compatibility with Kubernetes versions older than 1.16 to ensure compatibility with versions 1.22 and newer.
Add Kubernetes 1.22 to the KIC version compatibility matrix. It is supported by 2.0.x only.
* doc(kic) update Ingress documentation for 1.22 Update Ingress examples in documentation to use resources compatible with Kubernetes 1.22, which removes support for Ingress versions other than networking.k8s.io/v1: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes Replace ingress.class annotations on Ingress objects with ingressClassName fields. Although still supported, the ingress.class annotaion is deprecated. Note that KIC still lacks proper support for the associated IngressClass resource and treats ingressClassName effectively the same as the ingress.class annotation. Remove documentation for classless resources. These are no longer supported in KIC 2.x. Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com>
Update Ingress specs to properly adhere to v1 backend spec requirements and include pathType in rules.
* docs: major updates of istio guide * fix: broken links in overview * fix: wording in overview * fix: cluster notes in prereqs * fix: wording * fix: increase timeout for bookinfo wait * fix: duplicated navtab name * fix: broken links * fix: wording * fix: restructure sample request data example * fix: wording and order of kiali web setup * fix: broken link * first pass copyedit new Istio guide * fix curl capitalization * Update app/kubernetes-ingress-controller/2.0.x/guides/getting-started-istio.md Co-authored-by: Jennifer Rondeau <jennifer.rondeau@konghq.com>
* update redirect to point to live doc * adjust beta banner for legal reasons; set 1.3.x to not have an older version banner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with great thanks to all the folks who did the real work here 🎉
Continuation of #3081
Summary
This PR adds the upcoming (currently in alpha, soon to be beta) Kong Kubernetes Ingress Controller (KIC)
v2.0.x
documentation.Reason
New KIC BETA release is inbound, currently intended to be released within the next few days.
Supports Kong/kubernetes-ingress-controller#1095
Resolves Kong/kubernetes-ingress-controller#1652
Resolves Kong/kubernetes-ingress-controller#1674
Resolves #2903
Resolves #2904
Testing
All new content was tested explicitly by me, and implicitly by the new test suite.
Notes
I specifically seeded all the previous documentation from
v1.3.x
as the foundation forv2.0.x
in 4149c09, was this the right way to do things?Question: how do I flag this release as beta/preview in these docs?