Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCU-2185] Update Admin API note #3653

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[DOCU-2185] Update Admin API note #3653

merged 1 commit into from
Feb 11, 2022

Conversation

falondarville
Copy link
Contributor

@falondarville falondarville commented Feb 11, 2022

Summary

In the Admin API documentation, change Not available in DB-less mode. to This API is not available in DB-less mode.

Reason

Addresses DOCU-2185

Testing

One example: https://deploy-preview-3653--kongdocs.netlify.app/gateway/2.7.x/admin-api/#add-service

@falondarville falondarville added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Feb 11, 2022
@falondarville falondarville requested a review from a team as a code owner February 11, 2022 00:34
@netlify
Copy link

netlify bot commented Feb 11, 2022

✔️ Deploy Preview for kongdocs ready!

🔨 Explore the source changes: 3e2de52

🔍 Inspect the deploy log: https://app.netlify.com/sites/kongdocs/deploys/6205aefe1bcace00073e6a5a

😎 Browse the preview: https://deploy-preview-3653--kongdocs.netlify.app

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This change will need a parallel PR in the kong/kong repo, since this is a generated doc: https://github.com/Kong/kong/blob/master/autodoc/admin-api/generate.lua#L545

@lena-larionova
Copy link
Contributor

Manually checked the links, they're false positives.

@falondarville
Copy link
Contributor Author

LGTM. This change will need a parallel PR in the kong/kong repo, since this is a generated doc: https://github.com/Kong/kong/blob/master/autodoc/admin-api/generate.lua#L545

Kong/kong#8405

@falondarville falondarville merged commit ceb91b3 into main Feb 11, 2022
@falondarville falondarville deleted the docu-2185 branch February 11, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:manual-approve:link-validation review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants