feat: allow assigning KongPluginInstallation to GatewayConfiguration and DataPlane #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
enhancement
programmer04
force-pushed
the
custom-plugin-mount
branch
3 times, most recently
from
1c8f88f
to
6d1469a
Compare
programmer04
force-pushed
the
custom-plugin-mount
branch
2 times, most recently
from
f14564b
to
61f4b41
Compare
programmer04
force-pushed
the
custom-plugin-mount
branch
11 times, most recently
from
9e33515
to
b0b1da5
Compare
programmer04
force-pushed
the
custom-plugin-mount
branch
2 times, most recently
from
efb4710
to
e0b9544
Compare
1 task
programmer04
force-pushed
the
custom-plugin-mount
branch
7 times, most recently
from
f6b2a4c
to
bf5c1da
Compare
czeslavo
reviewed
Sep 13, 2024
czeslavo
reviewed
Sep 16, 2024
programmer04
force-pushed
the
custom-plugin-mount
branch
2 times, most recently
from
9ff849a
to
2c374eb
Compare
programmer04
force-pushed
the
custom-plugin-mount
branch
2 times, most recently
from
a742111
to
d96aa1a
Compare
czeslavo
approved these changes
Sep 20, 2024
programmer04
force-pushed
the
custom-plugin-mount
branch
from
d96aa1a
to
1af158b
Compare
pmalek
reviewed
Sep 23, 2024
pmalek
reviewed
Sep 23, 2024
programmer04
force-pushed
the
custom-plugin-mount
branch
from
1af158b
to
f514df8
Compare
programmer04
force-pushed
the
custom-plugin-mount
branch
2 times, most recently
from
28e257d
to
a1a74da
Compare
pmalek
reviewed
Sep 24, 2024
pmalek
approved these changes
Sep 24, 2024
…and DataPlane Co-authored-by: Patryk Małek <patryk.malek@konghq.com> Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
programmer04
force-pushed
the
custom-plugin-mount
branch
from
a1a74da
to
3f14182
Compare
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kong custom plugin built from
Dockerfilewhere
pluginis a directory that containshandler.luaandschema.luaas described in the official docs.Image with the aforementioned Kong custom plugin is available publicly under
northamerica-northeast1-docker.pkg.dev/k8s-team-playground/plugin-example/myheader-> adds headermyheader: roarnorthamerica-northeast1-docker.pkg.dev/k8s-team-playground/plugin-example/myheader-2(it's also mirrored inplugin-example-privaterequires auth) -> adds headernewheader: amazingThose are used in
config/samples/gateway-kongplugininstallation-httproute.yamland submitted as part of this PR and in the integration test.Functionality is implemented entirely. For each instance of Kong Gateway deployment, a dedicated
ConfigMapwith a custom plugin is created (based on sourceConfigMapmade as a result of the successful reconciliation ofKongPluginInstallation) and its lifecycle is tied to Kong Gateway. Such an approach although a little bit wasteful, because there are many duplications ofConfigMaps (but it's guaranteed that its size won't exceed 1MiB), greatly simplifies implementation. This is due to the limitation of Kubernetes - it's impossible to mount aConfigMapfrom another namespace to aDeployment. Furthermore, it reduces the blast radius of some mistakes, bugs, user actions, etc. to only one Dataplane - each one has its ownConfigMaps and reconciles them on its own.Which issue this PR fixes
Closes #380
Special notes for your reviewer:
Those "magic" images used in tests and examples will be documented/reworked to make them easy to maintain in the separate issue #465
Maybe more testing would be useful, e.g. with the usage of newly created
envtestsor more integration ones, I'm open to suggestions that I'm going to address in a separate PR.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes