chore: use IsZero() for ctr.Result to make check #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
reviewed
Sep 27, 2024
programmer04
force-pushed
the
requeue-check
branch
from
2e82fae
to
d3667c4
Compare
programmer04
changed the title
czeslavo
approved these changes
Sep 27, 2024
pmalek
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
During the review of #476 @pmalek mentioned that for
ctrl.Resultnot only the fieldRequeuebut alsoRequeueAfterindicates a need of requeue see #476 (comment). This PR ensures that both fields are checked in all cases with a built-in methodIsZero().Which issue this PR fixes
Spotted during the review of PR for the issue #380