Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(konnect): add KongSNI reconciler #653

Merged
merged 7 commits into from
Sep 30, 2024
Merged

feat(konnect): add KongSNI reconciler #653

merged 7 commits into from
Sep 30, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Sep 26, 2024 •
edited
Loading

What this PR does / why we need it:
Add KongSNI reconciler to operate Konnect SNIs.
Which issue this PR fixes

Fixes #598

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@randmonkey randmonkey added this to the KGO v1.4.x milestone Sep 26, 2024
@randmonkey randmonkey self-assigned this Sep 26, 2024
@randmonkey randmonkey force-pushed the feat/kong_sni_reconciler branch 4 times, most recently from 7fd4f21 to 9ec6a85 Compare September 30, 2024 08:31
@randmonkey randmonkey marked this pull request as ready for review September 30, 2024 08:40
@randmonkey randmonkey requested a review from a team as a code owner September 30, 2024 08:40
pmalek
pmalek reviewed Sep 30, 2024
View reviewed changes
controller/konnect/ops/ops_kongsni.go Outdated Show resolved Hide resolved
controller/konnect/ops/ops_kongtarget.go Outdated Show resolved Hide resolved
test/envtest/konnect_entities_sni_test.go Outdated Show resolved Hide resolved
modules/manager/controller_setup.go Outdated Show resolved Hide resolved
controller/konnect/watch_kongsni.go Outdated Show resolved Hide resolved
@pmalek pmalek changed the title KongSNI reconciler feat(konnect): add KongSNI reconciler Sep 30, 2024
@pmalek pmalek self-assigned this Sep 30, 2024
@pmalek pmalek force-pushed the feat/kong_sni_reconciler branch 2 times, most recently from 0299834 to fe61cec Compare September 30, 2024 11:38
@pmalek pmalek enabled auto-merge (squash) September 30, 2024 11:38
@pmalek pmalek merged commit c84710b into main Sep 30, 2024
21 checks passed
@pmalek pmalek deleted the feat/kong_sni_reconciler branch September 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees

@pmalek pmalek

@randmonkey randmonkey

Labels
area/konnect
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.

Konnect entities: SNI
2 participants
@randmonkey @pmalek