fix(core): Add a new parameter worker_event_max_payload to kong.conf
#11214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should bump lua-resty-events to 0.2.0, see: #11203 |
chronolaw
reviewed
Jul 12, 2023
chronolaw
reviewed
Jul 13, 2023
3 tasks
dndx
reviewed
Jul 13, 2023
liverpool8056
force-pushed
the
feat/worker_events_payload_size
branch
from
c94ec33
to
fee4454
Compare
chronolaw
reviewed
Jul 13, 2023
chronolaw
reviewed
Jul 13, 2023
chronolaw
reviewed
Jul 13, 2023
liverpool8056
force-pushed
the
feat/worker_events_payload_size
branch
from
eae4bb5
to
5d74f45
Compare
chronolaw
reviewed
Jul 13, 2023
liverpool8056
force-pushed
the
feat/worker_events_payload_size
branch
from
46699af
to
c3ea5e0
Compare
chronolaw
changed the title
worker_event_max_payload, to kong.confworker_event_max_payload to kong.conf
chronolaw
reviewed
Jul 13, 2023
liverpool8056
force-pushed
the
feat/worker_events_payload_size
branch
from
68da7d2
to
e41f286
Compare
chronolaw
reviewed
Jul 13, 2023
chronolaw
reviewed
Jul 13, 2023
liverpool8056
force-pushed
the
feat/worker_events_payload_size
branch
from
1a268df
to
2312715
Compare
chronolaw
approved these changes
Jul 14, 2023
chronolaw
force-pushed
the
feat/worker_events_payload_size
branch
from
d14925c
to
aa6f79d
Compare
|
This was not merged in time for Feature freeze so I have removed it from the milestone. Please get special approval from a director-level person in order to merge this feature before 3.4 GA. |
ADD-SP
approved these changes
Jul 19, 2023
chronolaw
changed the title
worker_event_max_payload to kong.confworker_event_max_payload to kong.conf
guanlan
dismissed
Tieske’s stale review
See the comment on https://konghq.atlassian.net/browse/FTI-4963?focusedCommentId=106900
team-gateway-bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
#11214) * With a hard-coded payload size, for some use cases like uploading a big OpenAPI spec in DevPortal or updating a big config entry for plugins, they can not work as expected. With the new parameter, the user can decide the payload size to meet their needs. In this PR, a new parameter, `worker_events_max_payload` is added, which allows to specify the payload size the `worker_events` lib can accept. The default size is 64k, and the max allowed to set is 16M Bytes. The corresponding PR for `worker_events` lib is [#37](Kong/lua-resty-events#37) FTI-4963 * add changelog entry * Update kong.conf.default Co-authored-by: Datong Sun <datong.sun@konghq.com> * add test case and bump lua-resty-events * correct the default value, and add an entry for bumping the version of lua-resty-events * 1. append PR number to the changelog entry of lua-resty-events 2. correct the spec test 3. style * Update CHANGELOG.md --------- Co-authored-by: Datong Sun <datong.sun@konghq.com> Co-authored-by: Chrono <chrono_cpp@me.com> (cherry picked from commit ff59edb)
chronolaw
added a commit
that referenced
this pull request
Jul 21, 2023
#11214) * With a hard-coded payload size, for some use cases like uploading a big OpenAPI spec in DevPortal or updating a big config entry for plugins, they can not work as expected. With the new parameter, the user can decide the payload size to meet their needs. In this PR, a new parameter, `worker_events_max_payload` is added, which allows to specify the payload size the `worker_events` lib can accept. The default size is 64k, and the max allowed to set is 16M Bytes. The corresponding PR for `worker_events` lib is [#37](Kong/lua-resty-events#37) FTI-4963 * add changelog entry * Update kong.conf.default Co-authored-by: Datong Sun <datong.sun@konghq.com> * add test case and bump lua-resty-events * correct the default value, and add an entry for bumping the version of lua-resty-events * 1. append PR number to the changelog entry of lua-resty-events 2. correct the spec test 3. style * Update CHANGELOG.md --------- Co-authored-by: Datong Sun <datong.sun@konghq.com> Co-authored-by: Chrono <chrono_cpp@me.com>
This was referenced Jul 21, 2023
windmgc
pushed a commit
that referenced
this pull request
Jul 21, 2023
#11214) * With a hard-coded payload size, for some use cases like uploading a big OpenAPI spec in DevPortal or updating a big config entry for plugins, they can not work as expected. With the new parameter, the user can decide the payload size to meet their needs. In this PR, a new parameter, `worker_events_max_payload` is added, which allows to specify the payload size the `worker_events` lib can accept. The default size is 64k, and the max allowed to set is 16M Bytes. The corresponding PR for `worker_events` lib is [#37](Kong/lua-resty-events#37) FTI-4963 * add changelog entry * Update kong.conf.default Co-authored-by: Datong Sun <datong.sun@konghq.com> * add test case and bump lua-resty-events * correct the default value, and add an entry for bumping the version of lua-resty-events * 1. append PR number to the changelog entry of lua-resty-events 2. correct the spec test 3. style * Update CHANGELOG.md --------- Co-authored-by: Datong Sun <datong.sun@konghq.com> Co-authored-by: Chrono <chrono_cpp@me.com> (cherry picked from commit ff59edb)
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a limit for the size of payload allowed to be send in events lib. In some cases, Kong needs to send big payload. For example DAO:crud rely on events to invalidate cache. In these cases, the size of the payload may exceeds the limit due a large dao entity, this can prevents logics relying on the events from executing properly.
In this PR, a new parameter,
worker_events_max_payloadis added, which allows to specify the payload size theworker_eventslib can accept. The default size is 64k, and the max allowed to set is 16M Bytes.The corresponding PR for
worker_eventslib is #37Checklist
Full changelog
Issue reference
FTI-4963