Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry]fix(core): Add a new parameter worker_event_max_payload to kong.con… #11257

Closed
wants to merge 1 commit into from

Conversation

chronolaw
Copy link
Contributor

…f (#11214)

  • With a hard-coded payload size, for some use cases like uploading a big OpenAPI spec in DevPortal or updating a big config entry for plugins, they can not work as expected. With the new parameter, the user can decide the payload size to meet their needs.

In this PR, a new parameter, worker_events_max_payload is added, which allows to specify the payload size the worker_events lib can accept. The default size is 64k, and the max allowed to set is 16M Bytes.

The corresponding PR for worker_events lib is #37

FTI-4963

  • add changelog entry

  • Update kong.conf.default

  • add test case and bump lua-resty-events

  • correct the default value, and add an entry for bumping the version of lua-resty-events

    1. append PR number to the changelog entry of lua-resty-events
  1. correct the spec test
  2. style
  • Update CHANGELOG.md

Summary

#11214

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

#11214)

* With a hard-coded payload size, for some use cases like uploading a big
OpenAPI spec in DevPortal or updating a big config entry for plugins,
they can not work as expected. With the new parameter, the user can
decide the payload size to meet their needs.

In this PR, a new parameter, `worker_events_max_payload` is added, which
allows to specify the payload size the `worker_events` lib can accept.
The default size is 64k, and the max allowed to set is 16M Bytes.

The corresponding PR for `worker_events` lib is [#37](Kong/lua-resty-events#37)

FTI-4963

* add changelog entry

* Update kong.conf.default

Co-authored-by: Datong Sun <datong.sun@konghq.com>

* add test case and bump lua-resty-events

* correct the default value, and add an entry for bumping the version of lua-resty-events

* 1. append PR number to the changelog entry of lua-resty-events
2. correct the spec test
3. style

* Update CHANGELOG.md

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Chrono <chrono_cpp@me.com>
@chronolaw
Copy link
Contributor Author

wrong cherry-pick

@chronolaw chronolaw closed this Jul 21, 2023
@chronolaw chronolaw deleted the cherry-pick/chrono-ff59edbd2-20230721 branch July 21, 2023 02:56
@chronolaw chronolaw restored the cherry-pick/chrono-ff59edbd2-20230721 branch July 21, 2023 02:56
@chronolaw chronolaw deleted the cherry-pick/chrono-ff59edbd2-20230721 branch July 21, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants