-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix balancer stop_healthchecks function table nil panic bug #12865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/balancer
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Apr 16, 2024
oowl
changed the title
fix(balancer): fix balancer stop_healthchecks function table nil panic bug
fix(core): fix balancer stop_healthchecks function table nil panic bug
Apr 17, 2024
windmgc
reviewed
Apr 17, 2024
vm-001
suggested changes
Apr 17, 2024
vm-001
suggested changes
Apr 18, 2024
chobits
reviewed
Apr 18, 2024
changelog/unreleased/kong/fix_balancer_healthecker_unexpected_panic.yml
Outdated
Show resolved
Hide resolved
windmgc
approved these changes
Apr 18, 2024
vm-001
approved these changes
Apr 18, 2024
Water-Melon
approved these changes
Apr 19, 2024
Successfully created cherry-pick PR for |
chobits
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix balancer stop_healthchecks function unexpected table nil panic
https://github.com/Kong/kong/blob/master/kong/runloop/balancer/healthcheckers.lua#L421
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #12811