Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix balancer stop_healthchecks function table nil panic bug #12865

Merged
merged 6 commits into from
Apr 19, 2024
Merged

fix(core): fix balancer stop_healthchecks function table nil panic bug #12865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86dd064
fix(balancer): fix balancer stop_healthchecks function table nil pani…
oowl Apr 16, 2024
5bf1b55
fix: fix code
oowl Apr 17, 2024
102723d
fix: fix code
oowl Apr 17, 2024
885e04d
fix: fix code
oowl Apr 18, 2024
42360a1
fix: fix code
oowl Apr 18, 2024
9182a5d
fix: fix code
oowl Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix_balancer_healthecker_unexpected_panic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: "**Core**: Fixed unexpected table nil panic in the balancer's stop_healthchecks function"
type: bugfix
scope: Core
7 changes: 6 additions & 1 deletion kong/runloop/balancer/healthcheckers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,12 @@ end
-- the health checker, this parameter is useful to avoid throwing away current
-- health status.
function healthcheckers_M.stop_healthcheckers(delay)
for _, id in pairs(upstreams.get_all_upstreams()) do
local all_upstreams, err = upstreams.get_all_upstreams()
if err then
log(ERR, "[healthchecks] failed to retrieve all upstreams: ", err)
return
end
for _, id in pairs(all_upstreams) do
local balancer = balancers.get_balancer_by_id(id)
if balancer then
healthcheckers_M.stop_healthchecker(balancer, delay)
Expand Down
Loading