fix(templates): add CSP headers for Admin GUI #14287
Draft
+169
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/templates
cherry-pick kong-ee
sumimakito
force-pushed
the
FTI-4283-security-headers
branch
from
b9ac457 to
7f0b16b
Compare
sumimakito
force-pushed
the
FTI-4283-security-headers
branch
from
7f0b16b to
c3e287f
Compare
sumimakito
force-pushed
the
FTI-4283-security-headers
branch
3 times, most recently
from
ff764f8 to
68ef6aa
Compare
sumimakito
force-pushed
the
FTI-4283-security-headers
branch
3 times, most recently
from
50e067f to
de82815
Compare
sumimakito
force-pushed
the
FTI-4283-security-headers
branch
from
de82815 to
a1c51b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds
Content-Security-PolicyandReferrer-Policyheaders while serving Admin GUI requests.Since the
Content-Security-Policyhas caused some issues with the Kong Manager before, we introduce a new configuration parameteradmin_gui_csp_headerwhich defaults to"off"to control the availability of this header. Users can opt in manually.As for the
Referrer-Policyheader, we will serve'strict-origin-when-cross-origin'which seems to be the default value today:Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-4283