perf(*) make some heavily used code paths more cooperative by yielding #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
changed the title
bungle
force-pushed
the
perf/yielding-more
branch
4 times, most recently
from
0f4121b to
cdc8e19
Compare
bungle
force-pushed
the
perf/yielding-more
branch
from
7139c75 to
dfc639e
Compare
bungle
changed the title
bungle
force-pushed
the
perf/yielding-more
branch
from
dfc639e to
8dfe7f0
Compare
### Summary Adds yielding to some hot paths that otherwise may cause latency spikes with huge Kong configurations. The special focus was to make CP/DP config changes less blocking.
bungle
force-pushed
the
perf/yielding-more
branch
from
8dfe7f0 to
1d7454d
Compare
|
Some initial tests show that this has a quite big improvement over max latency (the tests were ran in 2.8.1, where these were backported): We do some further testing, but it looks promising. |
kikito
approved these changes
Jun 2, 2022
This was referenced Jun 3, 2022
1 task
fffonion
pushed a commit
that referenced
this pull request
Jun 6, 2022
### Summary DP/CP's code is too complex and not human readable, it is hard to understand the callback workflows. This PR separates the logic of update_config, moves the code into an isolated file, and also de-coupled dp/cp modules. This PR is same as #8880, but solved the merge conflict of #8888. ### Full changelog * separates the logic of `update_config` into `config_helper.lua` * do not use `self` to mimic oop * remove duplicated functions `extract_major_minor `and `validate_shared_cert` in wrpc_cp * add many functions in `utils.lua` * remove `version_handshake` * pick #8888's yield feature in `to_sorted_string` * update config hash test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds yielding to some hot paths that otherwise may cause latency spikes with huge Kong configurations. The special focus was to make CP/DP config changes less blocking.