Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clustering) dpcp config clean #8893

Merged
merged 69 commits into from
Jun 6, 2022

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jun 3, 2022

Summary

DP/CP's code is too complex and not human readable, it is hard to understand the callback workflows.

This PR separates the logic of update_config, moves the code into an isolated file,
and also de-coupled dp/cp modules.

This PR is same as #8880, but solved the merge conflict of #8888.

Full changelog

Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the changeset is relatively large, my eye may miss something, so i'm relying on the tests to ensure it doesn't break. I went through the code from high level of view and didn't find obvious errors.

@fffonion fffonion merged commit 7ef980d into master Jun 6, 2022
@fffonion fffonion deleted the refactor/dpcp_config_clean_with_yield branch June 6, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants