-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(statsd) merge statsd-advanced into statsd #9046
Conversation
fc3a6e7
to
96d6546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please note that the docs should be merged after the original pr is merged. Kong/docs.konghq.com#4085
@vm-001 please also include the changelog entry in CHANGELOG.md |
The default metrics from statsd-advanced: [
"kong.node.eb6c7cacfddc.shdict.kong.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133373952|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.free_space:12492800|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.free_space:133419008|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.capacity:8388608|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.free_space:8327168|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.capacity:10485760|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.free_space:10412032|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.free_space:5197824|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.free_space:5201920|g",
"kong.route.5c8506d5-ff04-4c5c-bbc8-f20c5495cf46.user.robert.status.200:1|c",
"kong.service.statsd1.cache_datastore_hits_total:3|c",
"kong.service.statsd1.cache_datastore_misses_total:2|c",
"kong.service.statsd1.kong_latency:15|ms",
"kong.service.statsd1.latency:27|ms",
"kong.service.statsd1.request.count:1|c",
"kong.service.statsd1.request.size:119|ms",
"kong.service.statsd1.response.size:1451|ms",
"kong.service.statsd1.status.200:1|c",
"kong.service.statsd1.upstream_latency:12|ms",
"kong.service.statsd1.user.robert.request.count:1|c",
"kong.service.statsd1.user.robert.status.200:1|c",
"kong.service.statsd1.user.uniques:robert|s",
"kong.service.statsd1.workspace.1bf2f42d-4f41-4c84-89bd-2eb8f07fea44.status.200:1|c"
] The default metrics from statsd based on the latest commit of this branch. [
"kong.node.eb6c7cacfddc.shdict.kong.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133345280|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.free_space:12492800|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.free_space:133419008|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.capacity:8388608|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.free_space:8327168|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.capacity:10485760|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.free_space:10412032|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.free_space:5201920|g",
"kong.route.5c8506d5-ff04-4c5c-bbc8-f20c5495cf46.user.robert.status.200:1|c",
"kong.service.statsd1.cache_datastore_hits_total:3|c",
"kong.service.statsd1.cache_datastore_misses_total:2|c",
"kong.service.statsd1.kong_latency:12|ms",
"kong.service.statsd1.latency:41|ms",
"kong.service.statsd1.request.count:1|c",
"kong.service.statsd1.request.size:119|ms",
"kong.service.statsd1.request.status.200:1|c",
"kong.service.statsd1.request.status.total:1|c",
"kong.service.statsd1.response.size:1430|ms",
"kong.service.statsd1.upstream_latency:29|ms",
"kong.service.statsd1.user.robert.request.count:1|c",
"kong.service.statsd1.user.robert.request.status.200:1|c",
"kong.service.statsd1.user.robert.request.status.total:1|c",
"kong.service.statsd1.user.uniques:robert|s",
"kong.service.statsd1.workspace.718beb06-512f-4578-a5fb-21601904fb6f.status.200:1|c"
] |
kong/cache/init.lua
Outdated
local function cache_accessed(hit_lvl) | ||
local counter_name | ||
|
||
if hit_lvl == 2 then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add assert(type(hit_lvl) == 'number' && hit_lvl <=3)
?
Common code style issue: add blank line before |
diff 1.txt 2.txt
7c7
< "kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133373952|g",
---
> "kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133345280|g",
10,11d9
< "kong.node.eb6c7cacfddc.shdict.kong_counters.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_counters.free_space:1032192|g",
18,19d15
< "kong.node.eb6c7cacfddc.shdict.kong_keyring.capacity:5242880|g",
< "kong.node.eb6c7cacfddc.shdict.kong_keyring.free_space:5201920|g",
28,39d23
< "kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.free_space:1032192|g",
< "kong.node.eb6c7cacfddc.shdict.kong_reports_routes.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_reports_routes.free_space:1032192|g",
< "kong.node.eb6c7cacfddc.shdict.kong_reports_services.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_reports_services.free_space:1032192|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals.free_space:1032192|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.capacity:5242880|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.free_space:5197824|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.capacity:1048576|g",
< "kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.free_space:1032192|g",
45,46c29,30
< "kong.service.statsd1.kong_latency:15|ms",
< "kong.service.statsd1.latency:27|ms",
---
> "kong.service.statsd1.kong_latency:12|ms",
> "kong.service.statsd1.latency:41|ms",
49,51c33,36
< "kong.service.statsd1.response.size:1451|ms",
< "kong.service.statsd1.status.200:1|c",
< "kong.service.statsd1.upstream_latency:12|ms",
---
> "kong.service.statsd1.request.status.200:1|c",
> "kong.service.statsd1.request.status.total:1|c",
> "kong.service.statsd1.response.size:1430|ms",
> "kong.service.statsd1.upstream_latency:29|ms",
53c38,39
< "kong.service.statsd1.user.robert.status.200:1|c",
---
> "kong.service.statsd1.user.robert.request.status.200:1|c",
> "kong.service.statsd1.user.robert.request.status.total:1|c",
55c41
< "kong.service.statsd1.workspace.1bf2f42d-4f41-4c84-89bd-2eb8f07fea44.status.200:1|c"
---
> "kong.service.statsd1.workspace.718beb06-512f-4578-a5fb-21601904fb6f.status.200:1|c" Is the removal of these metrics expected? @vm-001 |
Because CE doesn't have those shdicts, I think it's totally fine to miss these metrics for Kong CE version. (@fffonion Correct me If I'm wrong) |
Sorry, I always use naked eyes to check style. |
Human Linter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests for cache_datastore_hits_total
and cache_datastore_misses_total
?
Tests count in kong-ee $ grep "it(" spec/03-plugins/06-statsd/01-log_spec.lua | wc -l
15
$ grep "it(" plugins-ee/statsd-advanced/spec/03-log_ee_spec.lua | wc -l
18 Tests count in this PR $ grep "it(" spec/03-plugins/06-statsd/01-log_spec.lua | wc -l
30 Are the three tests missing or got combined? @vm-001 |
< it("logs over UDP with default metrics with vitals on", function()
< it("logs over UDP with default metrics and new prefix with vitals on", function()
20d17
< it("vitals logging_metrics", function()
29c26
< it("logs service by service_name emits service.unnamed if service name is not set", function()
---
> it("logs service by service_name emits unnamed if service name is not set", function()
31c28,29
< it("does not send vitals metrics when vitals is turned off", function()
---
> it("logs over UDP with default metrics", function()
> it("latency as gauge", function()
@mayocream Thanks for potting out the different number of tests in ee and ce. I'm not seeing any problems.
|
@vm-001 Thanks for the detailed explanation; I am okay with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for overall looks good
2eff413
to
a9e7ab5
Compare
kong/cache/init.lua
Outdated
if err then | ||
return nil, "failed to get from node cache: " .. err | ||
end | ||
|
||
cache_accessed(hit_lvl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have performance number for this change? it looks like in a hot path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps, and it should only work if statsd plugin is enabled.
/perf simple |
/perf |
/perf simple |
kong/cache/init.lua
Outdated
@@ -150,16 +150,49 @@ function _M.new(opts) | |||
end | |||
|
|||
|
|||
local function cache_accessed(hit_lvl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache_accessed
this function is only used by the statsd plugin, and should not be placed in kong.cache
kong/cache/init.lua
Outdated
if err then | ||
return nil, "failed to get from node cache: " .. err | ||
end | ||
|
||
cache_accessed(hit_lvl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opps, and it should only work if statsd plugin is enabled.
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (simple) Click to expand
Download Artifacts for detailed results and interactive SVG flamegraphs. |
/perf simple |
🚀 Performance test resultTest Suite: 01-rps 02-flamegraph (simple) Click to expand
Download Artifacts for detailed results and interactive SVG flamegraphs. |
The default metrics of statsd with kong-ee: [
"kong.node.eb6c7cacfddc.shdict.kong.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133345280|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.free_space:12492800|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.free_space:133419008|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.capacity:8388608|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.free_space:8327168|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.capacity:10485760|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.free_space:10412032|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.free_space:5197824|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.free_space:5201920|g",
"kong.route.5c8506d5-ff04-4c5c-bbc8-f20c5495cf46.user.robert.status.200:1|c",
"kong.service.statsd1.cache_datastore_hits_total:3|c",
"kong.service.statsd1.cache_datastore_misses_total:2|c",
"kong.service.statsd1.kong_latency:15|ms",
"kong.service.statsd1.latency:27|ms",
"kong.service.statsd1.request.count:1|c",
"kong.service.statsd1.request.size:119|ms",
"kong.service.statsd1.request.status.200:1|c",
"kong.service.statsd1.request.status.total:1|c",
"kong.service.statsd1.response.size:1451|ms",
"kong.service.statsd1.upstream_latency:12|ms",
"kong.service.statsd1.user.robert.request.count:1|c",
"kong.service.statsd1.user.robert.request.status.200:1|c",
"kong.service.statsd1.user.robert.request.status.total:1|c",
"kong.service.statsd1.user.uniques:robert|s",
"kong.service.statsd1.workspace.1bf2f42d-4f41-4c84-89bd-2eb8f07fea44.status.200:1|c"
] The default metrics of statsd-advanced with kong-ee: [
"kong.node.eb6c7cacfddc.shdict.kong.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_cluster_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache.free_space:133345280|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_core_db_cache_miss.free_space:12492800|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_counters.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.capacity:134217728|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache.free_space:133419008|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_db_cache_miss.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_healthchecks.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_keyring.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.capacity:8388608|g",
"kong.node.eb6c7cacfddc.shdict.kong_locks.free_space:8327168|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.capacity:10485760|g",
"kong.node.eb6c7cacfddc.shdict.kong_mock_upstream_loggers.free_space:10412032|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_process_events.free_space:5201920|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.capacity:12582912|g",
"kong.node.eb6c7cacfddc.shdict.kong_rate_limiting_counters.free_space:12496896|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_consumers.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_routes.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_reports_services.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_counters.free_space:5197824|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.capacity:1048576|g",
"kong.node.eb6c7cacfddc.shdict.kong_vitals_lists.free_space:1032192|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.capacity:5242880|g",
"kong.node.eb6c7cacfddc.shdict.prometheus_metrics.free_space:5201920|g",
"kong.route.5c8506d5-ff04-4c5c-bbc8-f20c5495cf46.user.robert.status.200:1|c",
"kong.service.statsd1.cache_datastore_hits_total:3|c",
"kong.service.statsd1.cache_datastore_misses_total:2|c",
"kong.service.statsd1.kong_latency:15|ms",
"kong.service.statsd1.latency:27|ms",
"kong.service.statsd1.request.count:1|c",
"kong.service.statsd1.request.size:119|ms",
"kong.service.statsd1.response.size:1451|ms",
"kong.service.statsd1.status.200:1|c",
"kong.service.statsd1.upstream_latency:12|ms",
"kong.service.statsd1.user.robert.request.count:1|c",
"kong.service.statsd1.user.robert.status.200:1|c",
"kong.service.statsd1.user.uniques:robert|s",
"kong.service.statsd1.workspace.1bf2f42d-4f41-4c84-89bd-2eb8f07fea44.status.200:1|c"
] 49,50d48
< "kong.service.statsd1.request.status.200:1|c",
< "kong.service.statsd1.request.status.total:1|c",
51a50
> "kong.service.statsd1.status.200:1|c",
54,55c53
< "kong.service.statsd1.user.robert.request.status.200:1|c",
< "kong.service.statsd1.user.robert.request.status.total:1|c",
---
> "kong.service.statsd1.user.robert.status.200:1|c", |
/perf simple |
9112cbd
to
c0d91a2
Compare
CHANGELOG.md
Outdated
@@ -218,6 +220,7 @@ | |||
`kong.response.getRawBody`, `kong.service.response.getRawBody` and Python's `kong.request.get_raw_body`, | |||
`kong.response.get_raw_body`, `kong.service.response.get_raw_body` respectively. | |||
[#8623](https://github.com/Kong/kong/pull/8623) | |||
- Statsd Advanced Plugin has been deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line
@@ -337,6 +340,8 @@ | |||
- **AWS-Lambda**: add support for cross account invocation through | |||
configuration properties `aws_assume_role_arn` and | |||
`aws_role_session_name`.[#8900](https://github.com/Kong/kong/pull/8900) | |||
- **Statsd**: :fireworks: **Newly open-sourced plugin capabilities**: All capabilities of [Statsd Advanced](https://docs.konghq.com/hub/kong-inc/statsd-advanced/) are now bundled in [Statsd](https://docs.konghq.com/hub/kong-inc/statsd). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove these lines, no configuration changes were made
fa51832
to
f8cabed
Compare
cherry-pick from kong/kong-ee/#9046
Summary
Merge features of statsd-advanced into statsd
Full changelog
Issue reference
FTI-4110