chore(clustering): remove legacy hybrid protocol #9740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am very glad to see these changes, it do make our hybrid code more clean. The only question is when it will be approved? |
|
Reviewers: I'm aware this PR lacks a changelog entry and updates to the upgrade doc. I have an internal ticket assigned to myself for those items and will open a follow-up PR for them. |
flrgh
force-pushed
the
refactor/remove-legacy-hybrid-protocol
branch
from
f5b0e2c to
00ff3df
Compare
flrgh
force-pushed
the
refactor/remove-legacy-hybrid-protocol
branch
from
00ff3df to
644ca5d
Compare
flrgh
force-pushed
the
refactor/remove-legacy-hybrid-protocol
branch
from
644ca5d to
6a2101e
Compare
fffonion
added a commit
that referenced
this pull request
Nov 17, 2022
flrgh
added a commit
that referenced
this pull request
Nov 24, 2022
flrgh
added a commit
that referenced
this pull request
Nov 24, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy hybrid protocol.
Some code was moved out of
kong.clustering.control_planeintokong.clustering.utils, but aside from that, I have done as little refactoring as possible in order to keep the PR simple.