fix(clustering): restore json websocket protocol (#9921) #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog
core/clustering
core/configuration
core/templates
labels
chronolaw
commented
Jan 5, 2023
chronolaw
changed the title
chronolaw
commented
Jan 5, 2023
chronolaw
force-pushed
the
cherry-pick/restore-json-websocket-protocol
branch
from
8ba08af
to
957cc36
Compare
restore json_handler restore templates remove serve_wrpc_listener clean cp helpers.lua old update_compatible_payload fix compat.check_version_compa fix 09-config-compat_spec.lua fix sync blocked test fix sync allowed test 08-lazy_export remove wrpc related code remove wrpc related proto changelog remove wrpc code&test restore kong.model use compat.* change update_compatible_payload compat clean fix compat test restore proto restore wrpc lua restore wrpc test restore wrpc clustering restore wrpc rockspec enable clustering wrpc restore wrpc template wrpc_update_compatible_payload restore serve_wrpc_listener flag wrpc_hybrid_protocol test clustering_client_wrpc 08-lazy_export_spec.lua 03-pki_spec.lua 05-ocsp_spec.lua 02-start_stop_spec.lua 01-sync_spec.lua check_kong_version_compatibility force fallback remove fields test fix style fix KONG_VERSION changelog
chronolaw
force-pushed
the
cherry-pick/restore-json-websocket-protocol
branch
from
957cc36
to
61389eb
Compare
chronolaw
changed the title
flrgh
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Try to restore WebSocket protocol and keep wRPC protocol.
Revert PR #9740, update to PR #9823 #9769 , #9616 #9671 #9774.
This is the cherry-pick of #9921, and didn't remove wRPC protocol.
See KAG-371.
Related PRs: #8926 #8357
Checklist
Full changelog
control_plane.luawith newcompat.*compat.update_compatible_payloadto fit json+gzipwrpc_hybrid_protocolonly for test