-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kslideout): support optional title slot #1770
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
16fb12d
to
f1d4853
Compare
Just a bypasser here, but since I was involved in where this PR came from: I'm not totally sure if this should be a PR or just an issue, and not that I have much input over here but ideally any title/header type slots shouldn't be wrapped in a Just wanted to leave that as a note. |
Adds support for an optional `title` slot so that additional markup can be used in titles (e.g. a link). The slot takes priority over the prop. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
f1d4853
to
6c692bf
Compare
Closing this as it was superseded by #2012. |
Summary
Adds support for an optional
title
slot so that additional markup can be used in titles (e.g. a link). The slot takes priority over the prop.Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Note: Workaround for users of Kongponents v8: Use the
before-title
slot for both before title and title content and don’t provideprops.title
.PR Checklist