feat(kslideout): support optional title slot #1770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kleinfreund
force-pushed
the
feat/support-title-slot
branch
from
16fb12d
to
f1d4853
Compare
|
Just a bypasser here, but since I was involved in where this PR came from: I'm not totally sure if this should be a PR or just an issue, and not that I have much input over here but ideally any title/header type slots shouldn't be wrapped in a Just wanted to leave that as a note. |
This was referenced Oct 17, 2023
added 2 commits
December 15, 2023 14:11
Adds support for an optional `title` slot so that additional markup can be used in titles (e.g. a link). The slot takes priority over the prop. Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
Signed-off-by: Philipp Rudloff <philipp.rudloff@konghq.com>
kleinfreund
force-pushed
the
feat/support-title-slot
branch
from
f1d4853
to
6c692bf
Compare
|
Closing this as it was superseded by #2012. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for an optional
titleslot so that additional markup can be used in titles (e.g. a link). The slot takes priority over the prop.Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Note: Workaround for users of Kongponents v8: Use the
before-titleslot for both before title and title content and don’t provideprops.title.PR Checklist