fix(kslideout): title and content styles #1773
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Branched off of the work for #1770 so targeting that PR’s branch for now)
Summary
This PR mainly aims at reducing the need to override some of KSlideout’s default styles by making the layout a bit more consistent and adjusting the spacing between certain elements.
fix(kslideout): overriding KCard padding
Removes the custom padding override of
.kong-card
so that the content area has the same padding as KCard.fix(kslideout): title styles
Addresses a number of style issues of the title bar in order to achieve a better default appearance.
Removes the margins added to the title, before title, and after title containers and instead adds a padding to the header making the title bar appear flush with the content.
Reduces the gap size between title, before title, and after title to allow for more flexible usage scenarios.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Notes
The overrides we currently find ourselves using (with Kongponents v8) without these changes:
Screenshots
Before:
After:
PR Checklist