Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve resource processing logging #1755

Merged
merged 4 commits into from
Aug 26, 2021

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

Previously we have logged every cache update for the proxy which has proven to be noisy with very little gains, this patch removes those log entries.

Which issue this PR fixes

Resolves #1751

@shaneutt shaneutt added priority/low area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Aug 25, 2021
@shaneutt shaneutt added this to the Blockers for KIC 2.0 GA milestone Aug 25, 2021
@shaneutt shaneutt self-assigned this Aug 25, 2021
@shaneutt shaneutt requested a review from a team as a code owner August 25, 2021 18:55
@shaneutt shaneutt temporarily deployed to Configure ci August 25, 2021 19:04 Inactive
@rainest
Copy link
Contributor

rainest commented Aug 25, 2021

Maybe keep these but drop them down a verbosity level or two? These are actually useful confirmation that we haven't somehow failed to insert something into the store, and the issue is more that we stick a lot of useless garbage into the store.

@mflendrich mflendrich merged commit 12fa9f4 into main Aug 26, 2021
@mflendrich mflendrich deleted the improve-resource-processing-logging branch August 26, 2021 13:35
@mflendrich mflendrich temporarily deployed to Configure ci August 26, 2021 13:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/license/unchanged priority/low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix generated controller log print wording
3 participants