Add methods annotation #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2020 13:18
Add a new "konghq.com/methods" annotation for Ingress resources. This annotation sets the "methods" property of a Kong route.
Validate methods against the upstream pattern (all members must be uppercase alpha strings). Add error logs indicating the problem method.
hbagdi
reviewed
Apr 20, 2020
hbagdi
suggested changes
Apr 22, 2020
added 2 commits
April 22, 2020 17:03
When possible, convert malformed methods in annotations or KongIngresses to valid methods by trimming whitespace and uppercasing. Some methods (e.g. integers) will continue to fail. Revert previous change to logging due to consistency issues.
hbagdi
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the
konghq.com/methodsannotation for Ingress resources.Special notes for your reviewer:
This validates the methods array based on the upstream schema validation. It follows the pattern used for protocol validation: if any element is invalid, all elements are discarded and the controller logs an error.