Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs for previous PRs #638

Merged
merged 3 commits into from
May 8, 2020
Merged

Add missing docs for previous PRs #638

merged 3 commits into from
May 8, 2020

Conversation

rainest
Copy link
Contributor

@rainest rainest commented May 4, 2020

What this PR does / why we need it:
Docs for #628, #591, #597, and #609 were previously missing because most of them needed something from master. Master has since been merged into next, and these can now be added.

@rainest rainest requested a review from hbagdi May 4, 2020 23:45
Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but other-wise looks good.

docs/references/annotations.md Show resolved Hide resolved
@hbagdi hbagdi merged commit 1f27531 into next May 8, 2020
@hbagdi hbagdi deleted the doc/traines-missing-docs branch May 8, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants