Splitting off Jupyter yet again #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t some codegen logic. Refactored codegen paths from org.jetbrains.dataframe -> org.jetbrains.kotlinx.dataframe
Jolanrensen
force-pushed
the
jupyter-module
branch
from
69b58a6 to
4cfa0ce
Compare
Jolanrensen
force-pushed
the
jupyter-module
branch
from
ae058e5 to
7ae67ff
Compare
Jolanrensen
force-pushed
the
jupyter-module
branch
from
41fba75 to
78951d1
Compare
Merged
4 tasks
# Conflicts: # plugins/kotlin-dataframe/build.gradle.kts
koperagen
reviewed
Mar 14, 2025
| @@ -28,3 +25,6 @@ public data class CodeWithConverter(val declarations: Code, val converter: (Vari | |||
| else -> declarations + "\n" + converter(name) | |||
| } | |||
| } | |||
|
|
|||
| public typealias Code = String | |||
There was a problem hiding this comment.
Is it an option to not have these in public api?
There was a problem hiding this comment.
I think they're part of our codegen api. CodeWithConverter is public too after all
koperagen
reviewed
Mar 14, 2025
| @@ -26,7 +26,8 @@ repositories { | |||
| fun ExternalModuleDependency.excludeJaiCore() = exclude("javax.media", "jai_core") | |||
|
|
|||
| dependencies { | |||
| api(project(":core")) | |||
| api(projects.core) | |||
| implementation(projects.dataframeJupyter) | |||
There was a problem hiding this comment.
Why do we need geo to depend on impl jupyter?
There was a problem hiding this comment.
It uses useSchema<>() in its jupyter integration
There was a problem hiding this comment.
If we expect to use geo Integration to work only when jupyter Integration is configured (which should be), dependency can be compileOnly here
There was a problem hiding this comment.
I'm not 100% sure, @AndreiKingsley ?
There was a problem hiding this comment.
Let's fix this after merging, so we can revert back to java 8 sooner
koperagen
reviewed
Mar 14, 2025
koperagen
reviewed
Mar 14, 2025
...frame-jupyter/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #775
:dataframe-jupyterorg.jetbrains.dataframe->org.jetbrains.kotlinx.dataframein codegen partsTrying out Restrikt to do this responsibly.Restrikt seems too unstable for DF. Often getting compile errors in FIR or NoSuchElementExceptions in tests.