Ready dataframe.json for dataframe-jupyter module at v1.0+ #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds conditional statement to dataframe descriptor, allowing it to handle the integration being in `dataframe` before version 1.0 and in `dataframe-jupyter` after 1.0
Jolanrensen
force-pushed
the
dataframe-jupyter
branch
from
fe3e8d5 to
d76e956
Compare
Jolanrensen
commented
Mar 14, 2025
Comment on lines
+8
to
13
| "init": [ | ||
| "if (!\"$v\".startsWith('0')) USE { dependencies(\"org.jetbrains.kotlinx:dataframe-jupyter:$v\") }" | ||
| ], | ||
| "dependencies": [ | ||
| "org.jetbrains.kotlinx:dataframe:$v" | ||
| ], |
There was a problem hiding this comment.
This doesn't seem to work:
[ERROR] Failed to load library integration class 'org.jetbrains.kotlinx.dataframe.jupyter.Integration'
org/jetbrains/kotlinx/dataframe/impl/codeGen/ReplCodeGenerator
java.lang.NoClassDefFoundError: org/jetbrains/kotlinx/dataframe/impl/codeGen/ReplCodeGenerator
It seems to need the "dependencies" part to discover the full library in both cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds conditional statement to dataframe descriptor, allowing it to handle the integration being in
dataframebefore version 1.0 and indataframe-jupyterafter 1.0.Related to Kotlin/dataframe#1095
Type of change