Fix DGPv2 migration helpers #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
- Create `dokka${Format}${Subtype}Plugin` (e.g. `dokkaHtmlMultiModulePlugin`) Configurations.
- Now that DGP has HTML and Javadoc plugins, adjust the deprecated `dokkaRuntime` Configuration to redirect to the 'base' `dokkaGeneratorRuntime` Configuration instead of the HTML-specific `dokkaHtmlGeneratorRuntime`.
adam-enko
force-pushed
the
adam/feat/KT-70336/fix-migration-helpers
branch
from
35eed2b
to
5d0bfd8
Compare
whyoleg
approved these changes
Sep 17, 2024
Well, their main purpose is to ensure that we don't accidentally break users' buildscripts by changing the generated accessors. This PR is intentionally modifying the accessors, so we expect changes. But yes, the the actual changes are difficult to discern. |
Tapchicoma
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the DGPv2 migration helpers to better support migration.
dokka${Format}${Subtype}Plugin(e.g.dokkaHtmlMultiModulePlugin) Configurations.dokkaRuntimeConfiguration to redirect to the 'base'dokkaGeneratorRuntimeConfiguration instead of the HTML-specificdokkaHtmlGeneratorRuntime.