-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PReLU layer #85
Add PReLU layer #85
Conversation
Looks like something wrong with types, maybe usage int or long or double instead of float |
@zaleslaw I just fixed the tests and this is ready to be reviewed. It seems I had to use Graph mode instead of Eager mode to be able to correctly build the layer and run a forward pass on it; so I took inspiration from |
The eager mode in 1.15 was unstable and has a lot of bugs, I've used it for testing purposes only |
Hi, @mkaze please update your PR from master branch, be careful with weights (it's converted to var) and should have "get" and "set" methods to extract and assign weights. Notify me here and I will run TC builds |
@zaleslaw I merged it with master branch and updated the By the way, out of curiosity, are you the only one from JetBrains who is working on this project full-time? I was just wondering how much committed JetBrains is to push forward this project. |
@mkaze It's easy to see in the commit history:) Yes, I'm the only developer from JetBrains who assigned KotlinDL full-time. But, of course, not only my brains are committed to this project. Also, I'm part of Kotlin for Data Science Team, we are working together on Mutlik, data frame, lets-plot-dsl, and Kotlin kernel for Jupyter Notebook. I hope, if the project will be successful, the team will be extended, and the contributor community will grow! |
Resolves #54. This PR adds support for PReLU layer.
@zaleslaw, I have a problem with testing my implementation. As you can see, I have written a unit test to start with; however, it fails with the following error:
It seems the error happens in
build
method when it wants to initialize and add the weights of the layer. I tried to investigate what the issue is, but couldn't figure it out further... this happens even if I useDense
layer instead ofPReLU
in the unit test! I am not sure what I am missing?! Surely, you can help. Thanks!