Version 0.21.0 #305
Version 0.21.0 #305
Conversation
* JS Legacy build configurations as well as JS Legacy test projects were conditionally removed for KGP version >= 1.9.0 Co-authored-by: Stanislav Ruban <stanislav.ruban@jetbrains.com>
* Migrated from Gradle 6 to 7 * Updated atomicfu-maven-plugin publication
|
Some observations about the commit history we got here: there is a sequence of commits that exist out-of-context (e.g. neither tested nor thoroughly explained (e.g. 5f05039), with the final issue that is fixed also non-tested. They should've been squashed, with the detailed explanation why the changes are done. I'd suggest using Kotlin/kotlinx-kover#386 as an inspiration: the Gradle tweaks are documented, the test is provided, the commit message is extensive (e.g. why file collection was replaced with the provider, not the fact it was done) |
|
Thank you, yes, all these out-of-context commits from c201c53 to c41d50a were merged with this PR: #303. My mistake they were not squashed. The issue fixed there was reproduced by the existing test I can fix the history in this branch and merge it to master in a proper way (squash + extended comment). I would also add comments to all the changes for future understanding (some of them were just caused by using the new KGP API). |
Jar task for JVM-only projects packed both original and transformed classes with Kotlin 1.8.20 and Gradle 7.3.
This commit contains fix for the issue, plus some refactoring in AtomicfuGradlePlugin using KGP API introduced in 1.7.0.
* Fixed configuration of outputs classesDir: remove outputs of Kotlin compilation task and replace with atomicfu transformation task output
* Refactoring:
- Renamed the directory with original classes to `classes/atomicfu-orig/`
- Introduced 'destinationDirectory' for AtomicFUTransformTask
- Lazy registration of AtomicFU transform tasks
* Added minimal supported version of KGP and Gradle (KGP >= 1.7.0, Gradle >= 7.0)
Always configure test compilation dependencies Fixes #307
mvicsokolova
force-pushed
the
version-0.21.0
branch
from
456b472 to
11e1c0e
Compare
|
Commit fixing the issue with building JVM-only projects merged (88a5e14).
|
For targets that require IR transformation modification of compilation tasks output directories is not required. Classes from the original directories are transformed by the compiler plugin in place. Fixes #311
mvicsokolova
force-pushed
the
version-0.21.0
branch
from
11e1c0e to
8c3b92a
Compare
No description provided.